doc: reinstate stanford graph base documentation page with example - #585
Conversation
|
Boost dependency footprint vs Header-inclusion weights (graph files pulling each direct dependency in): No header-inclusion-weight changes. Transitive Boost modules: 66 → 66 (0) |
|
An automated preview of the documentation is available at https://585.graph.prtest3.cppalliance.org/libs/graph/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-09-02 12:01:22 UTC |
|
Compiler-warning counts vs
|
|
@ascherer the SGB interface documentation is back and available here: https://585.graph.prtest3.cppalliance.org/libs/graph/doc/html/graph/extending/stanford_graph.html Is there anything you would like to see ? 😄 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
|
@Becheler Thanks for the restauration. I have two annotations:
I am contemplating to suggest a major change in |
ba75ef4 to
e92e07a
Compare
|
Thank you @ascherer In the meantime I modernized one minimal example to run in our runnable CI examples I also added a small section describing to users what this SGB page is (not) about. https://585.graph.prtest3.cppalliance.org/libs/graph/doc/html/graph/extending/stanford_graph.html About your changes, I would be careful. I agree that having However changing the headers of BGL would break users including our CI since we rely on #if defined(__has_include) && __has_include(<sgb/gb_graph.h>)
# // use the sgb/ prefix
#else
# // use bare names
#endifMaybe we could add something to it like So in conclusion I do think the compatibility shim is the best of two worlds. |
Unfortunately, yes. Let's keep the interface intact. |
@ascherer Sorry if I was not clear, but unless I'm mistaken, this would support both layouts and not break anyone ? #if defined(__has_include) && __has_include(<sgb/gb_graph.h>)
// use the sgb/ prefix
#include <sgb/gb_graph.h>
#else
// use bare names
#include <gb_graph.h>
#endif |
|
@Becheler I'm not familiar with |
|
Good catch. Thinking about it, BGL is now C++14, and supported compiler/platforms (at least those in CI) all support the symbol IIUC. After looking around, it's also used across Boost Asio and Config: |
|
@Becheler As I said, I'm not familiar with Anyway, feel free to add the appropriate preprocessor logic in |
e92e07a to
6345572
Compare
Before submitting
developbranch.Type of change
Does this PR introduce a breaking change?
What this PR does
Reinstate the lost documentation page: https://www.boost.org/doc/libs/1_34_0/libs/graph/doc/stanford_graph.html
Motivation
Testing
Checklist
b2in thetest/directory).