[1/4] buzz-sdk: own the NIP-AP persona and team event shapes - #5842
Open
Maxwellimus wants to merge 1 commit into
Open
[1/4] buzz-sdk: own the NIP-AP persona and team event shapes#5842Maxwellimus wants to merge 1 commit into
Maxwellimus wants to merge 1 commit into
Conversation
Maxwellimus
marked this pull request as ready for review
August 14, 2026 06:22
wolfyy970
approved these changes
Aug 14, 2026
wolfyy970
left a comment
There was a problem hiding this comment.
Reviewed at exact head 1341b815ac4d. Moving the event shapes, tri-state team fields, coordinate helpers, and byte-stable persona serialization into buzz-sdk is the right first increment. Desktop still projects only explicit shared fields, and the extraction does not move launch, credentials, or machine configuration into the definition.
I reran the SDK contract tests plus Desktop persona/team event suites: 58 passed. Both Rust format checks and git diff --check are clean. The red smoke check is an unrelated Huddle voice-menu failure.
Maxwellimus
force-pushed
the
maxwell/nip-ap-sdk-event-shapes
branch
3 times, most recently
from
August 14, 2026 19:59
b13601c to
53a104d
Compare
Buzz Desktop was the only implementation of the kind:30175 / kind:30176 wire format. Anything else that wanted to publish an agent definition had to re-derive it, and a re-derivation that gets serde field order wrong produces different content bytes, a different event id, and a persona Desktop treats as unrelated to the one it already has. Move the builders, content structs, and coordinate helpers into `buzz_sdk::agent_definitions`; Desktop now calls them instead of holding its own copy. `double_option` moves with them, because the persona/team tri-state (absent = "unknown, preserve local" vs. null/[] = "explicitly cleared") is part of the wire contract rather than a Desktop detail. Field order is pinned by a byte-exact serialization test — a reorder would silently invalidate every stored `persona_content_hash`. Signed-off-by: Max Lampert <maxwell@squareup.com>
Maxwellimus
force-pushed
the
maxwell/nip-ap-sdk-event-shapes
branch
from
August 15, 2026 00:29
53a104d to
ad5984a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buzz Desktop was the only implementation of the kind:30175 / kind:30176 wire
format. Anything else that wanted to publish an agent definition had to
re-derive it, and a re-derivation that gets serde field order wrong produces
different content bytes, a different event id, and a persona Desktop treats as
unrelated to the one it already has.
Moves the builders, content structs, and coordinate helpers into
buzz_sdk::agent_definitions; Desktop calls them instead of holding its owncopy.
double_optionmoves with them, because the persona/team tri-state(absent = "unknown, preserve local" vs. null/
[]= "explicitly cleared") ispart of the wire contract rather than a Desktop detail.
Field order is pinned by a byte-exact serialization test — a reorder would
silently invalidate every stored
persona_content_hash.No behavior change; this is the extraction the rest of the stack builds on.
Test plan
just cicargo test --manifest-path desktop/src-tauri/Cargo.toml— existing personaand team event tests pass unchanged against the moved code.