Skip to content

fix(desktop): show every managed agent instance - #5575

Open
atishpatel wants to merge 4 commits into
mainfrom
brainy/agents-view-instances
Open

fix(desktop): show every managed agent instance#5575
atishpatel wants to merge 4 commits into
mainfrom
brainy/agents-view-instances

Conversation

@atishpatel

@atishpatel atishpatel commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Overview

Category: fix
User impact: The Agents page now shows every managed agent instance that mention autocomplete can target, even when multiple instances share the same persona and display name.

Problem: Mention autocomplete preserves managed-agent identity by pubkey, but the Agents page grouped agents by persona and selected only one representative. Multiple same-persona instances therefore appeared in autocomplete while all but one were hidden from the Agents page.

Solution:

  • Render one identity card per managed-agent pubkey within each persona group.
  • Show a truncated pubkey on managed cards so identically named instances are distinguishable.
  • Keep persona-only cards when no managed instance exists.
  • Keep persona-level edit/share/delete actions on the first stably sorted instance rather than duplicating them on every runtime card.
  • Preserve relay-restored managed agents, including the ingestion path changed by Relay-primary private managed-agent config #4999.

Reproduction steps

  1. Configure or restore two managed agents with the same persona ID.
  2. Confirm both identities appear in mention autocomplete.
  3. Open the Agents page.
  4. Before this fix, only one card appeared for that persona. With this fix, both pubkey-backed cards appear and can open their respective profiles.

Validation

At commit f2a0ecff82d36525c77e0ed7a2dd978a5785cdb6 with a clean working tree:

  • Pre-push desktop check, typecheck, and full unit suite passed (4,616 tests).
  • Purpose-built Playwright regression passed after a fresh E2E build.
  • Focused grouping tests passed (4 tests), including relay-restored and persona-only cases.
  • Mutation check passed: limiting the group back to one instance made the Playwright regression fail at the two-card assertion.
  • git diff --check passed.

Originating conversation: Buzz channel dcbc45d2-e9cc-45b3-940b-568dd06652ff, thread fd2e3ae323021b0314203dc0709f624669f278b344fdbe21f6cd65bae9582b2c.

Screenshot

Agents page with three managed Fizz instances sharing one persona. Each card is individually visible and distinguished by its truncated pubkey.

Agents page showing three same-persona managed instances


Generated with Brainy Bumble

Delete-popup UX proof

The individual-agent delete confirmation now makes the backup action visibly clickable with an underlined Export this agent link. Clicking it opens the existing export dialog. The seeded proof state shows 9 memories and 2 channels; both captures wait for the dialog animation to settle.

Individual-agent delete confirmation with underlined Export this agent link

Existing agent export dialog opened from the delete confirmation

atishpatel pushed a commit that referenced this pull request Aug 11, 2026
@atishpatel
atishpatel marked this pull request as ready for review August 11, 2026 17:06
@atishpatel
atishpatel requested a review from a team as a code owner August 11, 2026 17:06
@atishpatel
atishpatel force-pushed the brainy/agents-view-instances branch from 6b18ebe to b4a5c7c Compare August 12, 2026 13:30
atishpatel pushed a commit that referenced this pull request Aug 12, 2026
atishpatel pushed a commit that referenced this pull request Aug 12, 2026
@ScaleLeanChris

ScaleLeanChris commented Aug 12, 2026

Copy link
Copy Markdown

Validated this against a real multi-agent Buzz profile and the focused grouping suite.

The local managed-agent store contains 11 duplicated display names. Fizz, Bumble, and Honey each have two managed identities, so this is not only a synthetic collision. At 294d14f5a, the focused grouping tests pass: 4 passed, 0 failed. The new grouping preserves every pubkey-backed instance and stable ordering.

The truncated pubkey is useful for choosing the correct identity. It does not identify the execution host, which is the remaining source of confusion in a multi-machine fleet. I do not think that should block this focused PR. Host/body placement needs a stable body registry and belongs in #5667.

One current CI failure is the repository security audit reporting yanked transitive crates (async-utility and spin), not a finding in this Desktop-only diff.

Brainy Bumble and others added 4 commits August 12, 2026 11:02
Signed-off-by: Brainy Bumble <0ed7657b57c0e8a9f5288390dd6c8d5d0a3a06abe9b01b9006814f52077d6cdf@buzz.block.builderlab.xyz>
Co-authored-by: Atish Patel <atish@squareup.com>
Co-authored-by: Atish Patel <atish@squareup.com>
Signed-off-by: Atish Patel <atish@squareup.com>
Co-authored-by: Atish Patel <atish@squareup.com>
Signed-off-by: Atish Patel <atish@squareup.com>
Co-authored-by: Atish Patel <atish@squareup.com>
Signed-off-by: Atish Patel <atish@squareup.com>
@atishpatel
atishpatel force-pushed the brainy/agents-view-instances branch from 294d14f to e88957f Compare August 12, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants