Add glass appearance and cohesive settings - #5478
Conversation
|
🤖 Updated desktop snapshots for review. Appearance — lightTheme, glass, and preference controls in Buzz Light. Appearance — darkThe same hierarchy in Buzz Dark. Glass controlsOpt-in glass with the compact opacity slider. Shared settings surfaceSettings pages use the cohesive inset section treatment. Agent runtimesRuntime settings use compact rows within the shared section treatment. |
21b9bb3 to
705a63b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 705a63b445
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
705a63b to
6732dcc
Compare
Signed-off-by: kenny lopez <klopez4212@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6732dcc973
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Carl <3c4caeafb646d23867f1c4832e68211d77e2561946171625f75c3ce1a3f2670f@buzz.block.builderlab.xyz> Signed-off-by: Kenny Lopez <klopez4212@gmail.com>
wesbillman
left a comment
There was a problem hiding this comment.
Reviewed at a9959c7c943bcb9ea208c0d76c4bd5c41f1f771d on Wes's behalf.
No blocking findings. I traced the optional glass/native-vibrancy handshake, theme and preference state, settings reorganizations, runtime/mesh presentation changes, sidebar drag styling, and the focused E2E coverage. The latest head also addresses the earlier automated comments.
Validation on the exact clean head:
- desktop TypeScript typecheck passed
- Biome check passed for the changed implementation and focused E2E files
- desktop test suite passed: 4,544/4,544
git diff --checkpassed- GitHub currently reports the PR mergeable with all reported checks successful or skipped
- a merge-tree simulation against current
origin/main(f8f2ef0440e7a074223ec04dc3b32d817b8b9d9b) completed without conflicts
I am leaving this as a non-approving review because Wes has not delegated approval authority for this PR.
Keep the prominent active-tab treatment opt-in so fresh and existing profiles without the new preference retain Buzz's established selected-row surface. Update the focused E2E regression to cover the unset, enabled, and disabled states. Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
|
Follow-up fix pushed at The prominent active-tab treatment now defaults to Validation on the exact pushed head:
|
Co-authored-by: Kenny Lopez <klopez4212@gmail.com> Signed-off-by: Kenny Lopez <klopez4212@gmail.com>
…-glass-settings Signed-off-by: Fast Fizz <2df81cb51f05a9d5387ef24d7b9ecb8fcdfcd1c70ffabc67061c9596e1b5b1c4@buzz.block.builderlab.xyz>





Summary
Validation