Skip to content

Add glass appearance and cohesive settings - #5478

Open
klopez4212 wants to merge 7 commits into
mainfrom
kennylopez-appearance-glass-settings
Open

Add glass appearance and cohesive settings#5478
klopez4212 wants to merge 7 commits into
mainfrom
kennylopez-appearance-glass-settings

Conversation

@klopez4212

Copy link
Copy Markdown
Contributor

Summary

  • add an opt-in native glass sidebar with opacity controls and live theme previews
  • refine sidebar spacing and Buzz-only active rows while preserving production defaults
  • unify settings section cards, subtitles, and agent runtime rows

Validation

  • repository format, lint, type, and file-size checks
  • 4,538 desktop tests and 2,270 native desktop tests
  • desktop and web production builds
  • 1,261 mobile tests in the completed full gate
  • focused Playwright appearance, sidebar, settings, pairing, and runtime coverage

@klopez4212

Copy link
Copy Markdown
Contributor Author

🤖 Updated desktop snapshots for review.

Appearance — light

Theme, glass, and preference controls in Buzz Light.

appearance-light

Appearance — dark

The same hierarchy in Buzz Dark.

appearance-dark

Glass controls

Opt-in glass with the compact opacity slider.

glass-controls

Shared settings surface

Settings pages use the cohesive inset section treatment.

settings-surface

Agent runtimes

Runtime settings use compact rows within the shared section treatment.

agent-runtime-rows

klopez4212 added a commit that referenced this pull request Aug 10, 2026
@klopez4212
klopez4212 force-pushed the kennylopez-appearance-glass-settings branch from 21b9bb3 to 705a63b Compare August 10, 2026 14:46
@klopez4212
klopez4212 marked this pull request as ready for review August 10, 2026 14:46
@klopez4212
klopez4212 requested a review from a team as a code owner August 10, 2026 14:46

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 705a63b445

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/shared/styles/globals/avatar-framing.css Outdated
Comment thread desktop/tests/e2e/buzz-theme-screenshots.spec.ts
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
@klopez4212
klopez4212 force-pushed the kennylopez-appearance-glass-settings branch from 705a63b to 6732dcc Compare August 10, 2026 15:06
Signed-off-by: kenny lopez <klopez4212@gmail.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6732dcc973

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/tests/e2e/buzz-theme-screenshots.spec.ts Outdated
Co-authored-by: Carl <3c4caeafb646d23867f1c4832e68211d77e2561946171625f75c3ce1a3f2670f@buzz.block.builderlab.xyz>
Signed-off-by: Kenny Lopez <klopez4212@gmail.com>

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at a9959c7c943bcb9ea208c0d76c4bd5c41f1f771d on Wes's behalf.

No blocking findings. I traced the optional glass/native-vibrancy handshake, theme and preference state, settings reorganizations, runtime/mesh presentation changes, sidebar drag styling, and the focused E2E coverage. The latest head also addresses the earlier automated comments.

Validation on the exact clean head:

  • desktop TypeScript typecheck passed
  • Biome check passed for the changed implementation and focused E2E files
  • desktop test suite passed: 4,544/4,544
  • git diff --check passed
  • GitHub currently reports the PR mergeable with all reported checks successful or skipped
  • a merge-tree simulation against current origin/main (f8f2ef0440e7a074223ec04dc3b32d817b8b9d9b) completed without conflicts

I am leaving this as a non-approving review because Wes has not delegated approval authority for this PR.

Keep the prominent active-tab treatment opt-in so fresh and existing profiles
without the new preference retain Buzz's established selected-row surface.
Update the focused E2E regression to cover the unset, enabled, and disabled
states.

Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
@wesbillman

Copy link
Copy Markdown
Collaborator

Follow-up fix pushed at f7b942a1b77b87e657d4311cfec08e8e6e3415dd on Wes's behalf.

The prominent active-tab treatment now defaults to false, preserving Buzz's established subtle selected-row surface for profiles without the new preference. The focused E2E now explicitly covers the unset opt-in default, persisted enable, and persisted disable states.

Validation on the exact pushed head:

  • focused Playwright regression passed (1/1)
  • desktop TypeScript typecheck passed
  • Biome check passed for both changed files
  • mandatory pre-push gate passed, including desktop checks/typecheck/tests, mobile tests, Rust tests, Tauri checks, and branch-skew validation

Fast Fizz and others added 2 commits August 11, 2026 07:12
Co-authored-by: Kenny Lopez <klopez4212@gmail.com>
Signed-off-by: Kenny Lopez <klopez4212@gmail.com>
…-glass-settings

Signed-off-by: Fast Fizz <2df81cb51f05a9d5387ef24d7b9ecb8fcdfcd1c70ffabc67061c9596e1b5b1c4@buzz.block.builderlab.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants