Expand team and template workflows - #5198
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e10cc44ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
6e10cc4 to
6036287
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60362872fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Preserve template channel settings during edits, retain duplicated team metadata, clear deleted section defaults, and reject oversized team mentions before provisioning. Co-authored-by: kenny lopez <klopez4212@gmail.com> Signed-off-by: kenny lopez <klopez4212@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 696e3c74c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| continue; | ||
| } | ||
|
|
||
| tags.push([TEAM_MENTION_TAG, candidate.teamId, candidate.displayName]); |
There was a problem hiding this comment.
When a locally created team has a name longer than 200 characters, this code emits the name unchanged, but parse_team_mention rejects it at event construction. The send flow creates and starts unresolved persona agents before the event builder parses these tags, so the message fails after leaving agent/channel side effects; enforce the tag constraints when naming teams or preflight the generated team tags before agent preparation.
Useful? React with 👍 / 👎.
| style={{ | ||
| minWidth: "var(--radix-dropdown-menu-trigger-width)", | ||
| }} | ||
| {form.sectionDefaultTemplateId ? ( |
There was a problem hiding this comment.
When a user opens channel creation from a templated section on a fresh session and list_channel_templates fails, sectionDefaultTemplateId remains set because reconciliation only runs after a successful query. This branch therefore replaces the picker with a locked raw template ID, yet submission still creates the channel and applyCanvas/applyAgents silently return without query data, so none of the displayed section defaults are applied; block creation with a retryable error or unlock the template selection when loading fails.
Useful? React with 👍 / 👎.
| #[tauri::command] | ||
| pub async fn pick_channel_template_project_folder(app: AppHandle) -> Result<Vec<String>, String> { |
There was a problem hiding this comment.
This new public Tauri command has no rustdoc explaining that it opens a multi-folder picker, returns an empty list on user cancellation, and can fail for invalid paths. Add a doc comment before exposing it as part of the command API.
AGENTS.md reference: AGENTS.md:L117-L117
Useful? React with 👍 / 👎.
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
Reviewed on Wes's behalf at exact head 696e3c74c0d2886a2fbce982406b1e7491cab456.
Changes requested. The main team/template workflows are thoughtfully covered, and I verified the previous findings for preserving template visibility/type, retaining duplicated team metadata, rejecting >50 mention targets before provisioning, clearing deleted section defaults after a successful fetch, and suppressing ambiguous team autocomplete. However, three user-facing failure paths remain, plus commit attribution.
-
P2 — invalid team mention metadata is rejected only after agent/channel side effects.
create_teamandupdate_teamaccept any nonblank team name, whileparse_team_mentionrejects names over 200 characters or containing controls.sendMessageWithMentionFlowpreflights only audience cardinality, then may prepare a DM channel and provision/start/attach team agents beforebuildMentionTagsreaches event construction. A locally created/imported team with a >200-character name therefore leaves those side effects and fails to send. Validate team name/tag constraints at team create/import/update time, or preflight the complete generated team tags beforeonPrepareSendChanneland agent preparation. Existing inline finding: #5198 (comment) -
P2 — a section-template fetch failure displays defaults that are not applied. On a fresh session,
sectionDefaultTemplateIdremains locked whileuseChannelTemplatesQueryis errored/loading. The form still permits submit; channel creation succeeds with the stale ID, thenapplyCanvas/applyAgentssilently return because query data is unavailable. The UI promised section defaults but created a plain channel. Make the state explicit: block with a retryable template-load error, or unlock/clear the section default on terminal query failure. Existing inline finding: #5198 (comment) -
Public API documentation: the new
pick_channel_template_project_folderTauri command lacks the doc comment required byAGENTS.md:114-117. Document its multi-folder behavior, cancellation result, and invalid-path failure contract. Existing inline finding: #5198 (comment) -
Commit attribution: final commit
696e3c74cis authored by Fast Fizz and co-authored/signed by Kenny. For agent-implementedblock/buzzwork, the responsible human must be author and signatory; the implementing agent belongs inCo-authored-by. Rewrite that commit with Kenny as author +Signed-off-by, and Fast Fizz as co-author.
Focused exact-head validation:
- 50/50 focused desktop unit tests passed (team candidate/resolution, mention-limit preflight, section storage, mention rendering metadata).
- Full GitHub CI is terminal green/skipped as expected.
- A focused Tauri Rust test build could not start tests because the fresh worktree lacks generated sidecar
desktop/src-tauri/binaries/buzz-acp-aarch64-apple-darwin; this is an environment setup failure, not an assertion failure. CI's Tauri/Rust checks passed.
Behavioral test changes for Wes: this PR substantially expands E2E coverage around team creation/import/mentions and channel/template/section workflows, and adds focused tests for team ambiguity, mention expansion, the 50-target boundary, section template persistence, and team-chip rendering. The existing test changes add new behavior; they do not appear to weaken prior assertions.
2 participants
Summary
Testing