Skip to content

Add GroupsAuthorizationService and a new group access endpoint - #8213

Draft
r-tome wants to merge 2 commits into
ac/pm-12473/collection-user-access-delta-endpointfrom
ac/pm-12473/groups-authorization-service
Draft

Add GroupsAuthorizationService and a new group access endpoint#8213
r-tome wants to merge 2 commits into
ac/pm-12473/collection-user-access-delta-endpointfrom
ac/pm-12473/groups-authorization-service

Conversation

@r-tome

@r-tome r-tome commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.37%. Comparing base (43e0705) to head (b674bfc).

❗ There is a different number of reports uploaded between BASE (43e0705) and HEAD (b674bfc). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (43e0705) HEAD (b674bfc)
3 2
Additional details and impacted files
@@                                  Coverage Diff                                  @@
##           ac/pm-12473/collection-user-access-delta-endpoint    #8213      +/-   ##
=====================================================================================
- Coverage                                              68.68%   63.37%   -5.31%     
=====================================================================================
  Files                                                   2394     2396       +2     
  Lines                                                 104353   104441      +88     
  Branches                                                9458     9472      +14     
=====================================================================================
- Hits                                                   71677    66193    -5484     
- Misses                                                 30338    36004    +5666     
+ Partials                                                2338     2244      -94     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@r-tome
r-tome force-pushed the ac/pm-12473/collection-user-access-delta-endpoint branch from bebf875 to aaf8357 Compare August 14, 2026 10:29
@r-tome
r-tome force-pushed the ac/pm-12473/groups-authorization-service branch from 52b6dd3 to 3746148 Compare August 14, 2026 10:29
r-tome added 2 commits August 14, 2026 11:53
Mirrors CollectionAuthorizationService's pattern for GroupsController: one
service that fetches its own data and calls the shared static
CollectionRules, instead of the inline ASP.NET authorization checks in Put.
Adds a new, additive PATCH organizations/{orgId}/groups/{id} endpoint behind
a feature flag that preserves Put's exact current behavior (full-list model,
self-add-to-group check, preserve-readonly-collections merge), reusing the
existing request model and persistence command.
@r-tome
r-tome force-pushed the ac/pm-12473/groups-authorization-service branch from 3746148 to b674bfc Compare August 14, 2026 10:54
@r-tome
r-tome force-pushed the ac/pm-12473/collection-user-access-delta-endpoint branch from aaf8357 to 43e0705 Compare August 14, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant