[PM-41870] Allow save prompt and fallback to writable collection when organization data ownership is enabled - #7259
Open
woliver99 wants to merge 2 commits into
Open
Conversation
Collaborator
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
Author
|
Just realised that auto-selecting the first collection might lead to saving into the wrong collection if a user has access to multiple collections. What if instead we only auto-select if there’s exactly one collection available? That way if they have multiple collections, they’re still forced to pick one. This would also match how the web extension and desktop app handle it. Let me know if you prefer that and I can update the code! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Closes #7256 PM-41838
📔 Objective
AutofillProcessorImpl.ktthat was automatically canceling Autofill save requests wheneverORGANIZATION_DATA_OWNERSHIPpolicy was enabled.getDefaultCollectionViewOrNull()inCipherViewExtensions.ktso that whenDEFAULT_USER_COLLECTIONis null, the app automatically selects the first writable collection as a fallback for much better UX.📸 Screenshots
1. Autofill Save Prompt
2. Collection Default Selection