Skip to content

[PM-41870] Allow save prompt and fallback to writable collection when organization data ownership is enabled - #7259

Open
woliver99 wants to merge 2 commits into
bitwarden:mainfrom
woliver99:fix/autofill-save-org-policy
Open

[PM-41870] Allow save prompt and fallback to writable collection when organization data ownership is enabled#7259
woliver99 wants to merge 2 commits into
bitwarden:mainfrom
woliver99:fix/autofill-save-org-policy

Conversation

@woliver99

@woliver99 woliver99 commented Aug 11, 2026

Copy link
Copy Markdown

🎟️ Tracking

Closes #7256 PM-41838

📔 Objective

  1. Removes an early return in AutofillProcessorImpl.kt that was automatically canceling Autofill save requests whenever ORGANIZATION_DATA_OWNERSHIP policy was enabled.
  2. Updates getDefaultCollectionViewOrNull() in CipherViewExtensions.kt so that when DEFAULT_USER_COLLECTION is null, the app automatically selects the first writable collection as a fallback for much better UX.

📸 Screenshots

1. Autofill Save Prompt

Before After
old-autofill new-autofill

2. Collection Default Selection

Before After
old-default new-default

@woliver99
woliver99 requested review from a team and david-livefront as code owners August 11, 2026 22:25
@CLAassistant

CLAassistant commented Aug 11, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot

Copy link
Copy Markdown
Collaborator

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-41870
Link: https://bitwarden.atlassian.net/browse/PM-41870

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title Allow save prompt and fallback to writable collection when organization data ownership is enabled [PM-41870] Allow save prompt and fallback to writable collection when organization data ownership is enabled Aug 11, 2026
@woliver99

woliver99 commented Aug 12, 2026

Copy link
Copy Markdown
Author

Just realised that auto-selecting the first collection might lead to saving into the wrong collection if a user has access to multiple collections.

What if instead we only auto-select if there’s exactly one collection available? That way if they have multiple collections, they’re still forced to pick one. This would also match how the web extension and desktop app handle it.

Let me know if you prefer that and I can update the code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PM-41838] "Ask to add item" prompt fails when Personal Vault is disabled

3 participants