fix: fail fast when Engine API JWT secret is left at shared default - #1160
fix: fail fast when Engine API JWT secret is left at shared default#1160erhnysr wants to merge 1 commit into
Conversation
The committed .env.mainnet and .env.sepolia shipped a shared, hardcoded BASE_NODE_L2_ENGINE_AUTH_RAW that any deployment would silently run on if left unchanged. Replace it with a placeholder and make consensus-entrypoint and execution-entrypoint fail fast when the placeholder is still in place, so a node cannot start on an unconfigured secret. Closes base#1159
🟡 Heimdall Review Status
|
|
Still live on today's main ( Pulled and re-checked against current Guard verified both ways Ran the guard directly (the exact block from each entrypoint, not through a full Docker run) both ways:
Precedent None of the comparable clients commit a usable shared secret:
base/node is the only one of the four committing a working shared secret to version control. |
Fixes #1159.
.env.mainnetand.env.sepoliashipped the same hardcodedBASE_NODE_L2_ENGINE_AUTH_RAW, so a deployment that never overrides it silently runs on a shared default. This replaces the committed value with a placeholder and makes both entrypoints fail fast when the placeholder is still in place.Changes
.env.mainnet/.env.sepolia: replace the hardcoded secret with<your-secret-jwt>and a# [REQUIRED] Generate with: openssl rand -hex 32comment.consensus-entrypoint: existing non-empty check now also rejects the placeholder, with a message pointing atopenssl rand -hex 32.execution-entrypoint: add the same guard before the secret is written to the JWT file, so reth never starts on the placeholder.Behaviour
Minimal by design — placeholder + guard only, no doc restructuring.