fix(demos): apply npm audit fix to trading-agent and demo_notif_app - #133
Open
memosr wants to merge 1 commit into
Open
fix(demos): apply npm audit fix to trading-agent and demo_notif_app#133memosr wants to merge 1 commit into
memosr wants to merge 1 commit into
Conversation
`npm audit fix` without `--force`, run with `--package-lock-only`, so only the two lockfiles change. No `package.json`, no application code. | App | before | after | | --- | --- | --- | | `agents/trading-agent` | 3 (1 critical, 1 high, 1 low) | 1 (low) | | `apps/demo_notif_app` | 15 (11 high, 3 moderate, 1 low) | 5 (4 high, 1 moderate) | Direct dependencies that moved: handlebars 4.7.8 -> 4.7.9 in trading-agent, viem 2.47.12 -> 2.56.3 in demo_notif_app. Everything else is transitive. `npm ci && npm run build` passes in both. What is left is what `npm audit fix` cannot reach without a major bump: trading-agent keeps one low esbuild advisory that only affects the dev server on Windows, and demo_notif_app keeps four advisories whose only fix path is a breaking upgrade. Not included: `base-account/agent-spend-permissions`. Its remaining high advisories all come from `@coinbase/cdp-sdk`'s old Solana stack, and the only fix `npm audit` offers is cdp-sdk 1.55.0. From 1.53.0 onward the SDK declares `@x402/svm` as an optional peer dependency but imports it unconditionally from `_esm/actions/x402/signX402Payment.js`, so `next build` fails with "Can't resolve '@x402/svm/exact/client'". That app also declares `@coinbase/cdp-sdk`, `@x402/evm` and `@x402/fetch` as `latest`, so a lockfile pin alone would not hold on a fresh `npm install`. It needs its own change.
memosr
force-pushed
the
fix/dependency-vulnerabilities
branch
from
September 5, 2026 20:32
18498e7 to
06b3790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm audit fixwithout--force, run with--package-lock-only, so only the two lockfiles change. Nopackage.json, no application code.agents/trading-agentapps/demo_notif_appCounts are from
npm audit --package-lock-onlyagainst currentmaster, re-run for this revision.Direct dependencies that moved
agents/trading-agent: handlebars 4.7.8 -> 4.7.9apps/demo_notif_app: viem 2.47.12 -> 2.56.3Everything else in the diff is transitive.
Verification
npm ci && npm run buildpasses in both apps.What is left
What
npm audit fixcannot reach without a major bump: trading-agent keeps one low esbuild advisory that only affects the dev server on Windows, and demo_notif_app keeps four advisories whose only fix path is breaking.Not included: base-account/agent-spend-permissions
Its remaining high advisories all come from
@coinbase/cdp-sdk's old Solana stack, and the only fixnpm auditoffers is cdp-sdk 1.55.0. From 1.53.0 onward the SDK declares@x402/svmas an optional peer dependency but imports it unconditionally from_esm/actions/x402/signX402Payment.js, sonext buildfails:cdp-sdk 1.38.4 through 1.52.0 carry the Solana fix without that import, but the app declares
@coinbase/cdp-sdk,@x402/evmand@x402/fetchaslatest, so a lockfile pin alone would not survive a freshnpm install. That app needs its own change and is left out here.