Skip to content

fix(demos): apply npm audit fix to trading-agent and demo_notif_app - #133

Open
memosr wants to merge 1 commit into
base:masterfrom
memosr:fix/dependency-vulnerabilities
Open

fix(demos): apply npm audit fix to trading-agent and demo_notif_app#133
memosr wants to merge 1 commit into
base:masterfrom
memosr:fix/dependency-vulnerabilities

Conversation

@memosr

@memosr memosr commented Jul 4, 2026

Copy link
Copy Markdown

Summary

npm audit fix without --force, run with --package-lock-only, so only the two lockfiles change. No package.json, no application code.

App before after
agents/trading-agent 3 (1 critical, 1 high, 1 low) 1 (low)
apps/demo_notif_app 15 (11 high, 3 moderate, 1 low) 5 (4 high, 1 moderate)

Counts are from npm audit --package-lock-only against current master, re-run for this revision.

Direct dependencies that moved

  • agents/trading-agent: handlebars 4.7.8 -> 4.7.9
  • apps/demo_notif_app: viem 2.47.12 -> 2.56.3

Everything else in the diff is transitive.

Verification

npm ci && npm run build passes in both apps.

What is left

What npm audit fix cannot reach without a major bump: trading-agent keeps one low esbuild advisory that only affects the dev server on Windows, and demo_notif_app keeps four advisories whose only fix path is breaking.

Not included: base-account/agent-spend-permissions

Its remaining high advisories all come from @coinbase/cdp-sdk's old Solana stack, and the only fix npm audit offers is cdp-sdk 1.55.0. From 1.53.0 onward the SDK declares @x402/svm as an optional peer dependency but imports it unconditionally from _esm/actions/x402/signX402Payment.js, so next build fails:

./node_modules/@coinbase/cdp-sdk/_esm/actions/x402/signX402Payment.js
Module not found: Can't resolve '@x402/svm/exact/client'

cdp-sdk 1.38.4 through 1.52.0 carry the Solana fix without that import, but the app declares @coinbase/cdp-sdk, @x402/evm and @x402/fetch as latest, so a lockfile pin alone would not survive a fresh npm install. That app needs its own change and is left out here.

`npm audit fix` without `--force`, run with `--package-lock-only`, so only
the two lockfiles change. No `package.json`, no application code.

| App | before | after |
| --- | --- | --- |
| `agents/trading-agent` | 3 (1 critical, 1 high, 1 low) | 1 (low) |
| `apps/demo_notif_app` | 15 (11 high, 3 moderate, 1 low) | 5 (4 high, 1 moderate) |

Direct dependencies that moved: handlebars 4.7.8 -> 4.7.9 in trading-agent,
viem 2.47.12 -> 2.56.3 in demo_notif_app. Everything else is transitive.

`npm ci && npm run build` passes in both.

What is left is what `npm audit fix` cannot reach without a major bump:
trading-agent keeps one low esbuild advisory that only affects the dev
server on Windows, and demo_notif_app keeps four advisories whose only fix
path is a breaking upgrade.

Not included: `base-account/agent-spend-permissions`. Its remaining high
advisories all come from `@coinbase/cdp-sdk`'s old Solana stack, and the
only fix `npm audit` offers is cdp-sdk 1.55.0. From 1.53.0 onward the SDK
declares `@x402/svm` as an optional peer dependency but imports it
unconditionally from `_esm/actions/x402/signX402Payment.js`, so `next build`
fails with "Can't resolve '@x402/svm/exact/client'". That app also declares
`@coinbase/cdp-sdk`, `@x402/evm` and `@x402/fetch` as `latest`, so a
lockfile pin alone would not hold on a fresh `npm install`. It needs its own
change.
@memosr
memosr force-pushed the fix/dependency-vulnerabilities branch from 18498e7 to 06b3790 Compare September 5, 2026 20:32
@memosr memosr changed the title fix: resolve dependency vulnerabilities in 3 demo apps fix(demos): apply npm audit fix to trading-agent and demo_notif_app Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant