fix: OnTimeoutElapsed crashes / refactor to use upstream version (fix… - #1925
Open
linkdotnet wants to merge 1 commit into
Open
fix: OnTimeoutElapsed crashes / refactor to use upstream version (fix…#1925linkdotnet wants to merge 1 commit into
linkdotnet wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
A critical timer disposal race can cause ObjectDisposedException during invocation handling.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Refactors JSInterop timeout handling and adds regression coverage for timeout/result races.
Changes:
- Tracks pending invocations independently.
- Adds timeout and concurrency tests.
- Documents the fix in the changelog.
File summaries
| File | Description |
|---|---|
tests/bunit.tests/JSInterop/BunitJSInteropTimeoutTest.cs |
Adds timeout and race-condition tests. |
src/bunit/JSInterop/InvocationHandlers/JSRuntimeInvocationHandlerBase{TResult}.cs |
Refactors invocation and timeout handling. |
CHANGELOG.md |
Records the timeout crash fix. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ripped from https://github.com/dotnet/aspnetcore/blob/main/src/JSInterop/Microsoft.JSInterop/src/JSRuntime.cs