Compare protocol-test list headers semantically; add runner skip list - #3920
Open
pulimsr wants to merge 1 commit into
Open
Compare protocol-test list headers semantically; add runner skip list#3920pulimsr wants to merge 1 commit into
pulimsr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test-only improvements to the generated protocol tests:
AwsProtocolTestHelpers.h): list header values are now compared with optional whitespace around commas normalized per RFC 7230, soa, b, canda,b,care treated as equivalent. Element order, content, and quoting remain significant, so meaningful differences are still caught. Follows the same approach used for XML, query, and form-urlencoded bodies in Protocol tests updates #3900.run_protocol_tests.py): adds an explicit, annotated list of cases the runner skips, so unrelated known-open items (and any test that aborts its binary) don't mask results for the rest of the suite. Entries are annotated so the list can be revisited and trimmed over time.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.