fix/bidirectional stream shutdown - #3919
Open
pulimsr wants to merge 4 commits into
Open
Conversation
sbiscigl
approved these changes
Sep 3, 2026
sbiscigl
force-pushed
the
test/bidirectional-stream-shutdown
branch
from
September 4, 2026 17:55
13d04b2 to
64832a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #3911 & #3917
Aws::ShutdownAPI()hung indefinitely afterInvokeModelWithBidirectionalStreamAsync()because a reference cycle (stream → signing callback → ctx → httpRequest → body → stream) kept an HTTP/2 connection alive, blockingCleanupCrtin~ClientBootstrap.eddb695, @sbiscigl): releasem_stream/m_connectioninHttpWriteDataStreamBuf::WaitForStreamComplete(); drop theeventEncoderStreamself-capture in codegen.RunTests.cppthat turns a future hang into SIGABRT on any platform.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.