fix: bypass proxy for Runtime and Extensions API calls - #641
Merged
Merged
Conversation
The Runtime and Extensions API clients built a bare http.Client, which inherits http.DefaultTransport and its ProxyFromEnvironment behavior. A customer-configured HTTP(S)_PROXY then routed calls to the API endpoint through the proxy, so a proxy in the environment could break function init even though it should never affect communication with the API. Give both clients a transport that never proxies, cloned from the default so connection-pooling and timeout defaults are preserved.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
+ Coverage 82.38% 82.94% +0.56%
==========================================
Files 36 36
Lines 1419 1425 +6
==========================================
+ Hits 1169 1182 +13
+ Misses 247 240 -7
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The Runtime and Extensions API clients built a bare http.Client, which inherits http.DefaultTransport and its ProxyFromEnvironment behavior. A customer-configured HTTP(S)_PROXY then routed calls to the API endpoint through the proxy, so a proxy in the environment could break function init even though it should never affect communication with the API.
Give both clients a transport that never proxies, cloned from the default so connection-pooling and timeout defaults are preserved.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.