Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1815
Description of changes:
Following the approach suggested in the issue: when the marshalled response body is larger than the 6 MB Lambda payload limit,
APIGatewayProxyFunctionandAPIGatewayHttpApiV2ProxyFunctionnow return a 413 (and log an error) instead of the invocation failing with an opaque error. The check runs inMarshallResponsebeforePostMarshallResponseFeature, so users can still customize the 413 response.Utilities.IsResponseBodyTooLarge: base64 bodies are measured by string length, text bodies by UTF-8 byte count.Amazon.Lambda.AspNetCoreServer(patch).LargeResponseControllerin TestWebApp. All 233 tests inAmazon.Lambda.AspNetCoreServer.Testpass on net8.0 and net10.0.Notes for review:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.