Repository navigation
feat: add the ESDK TestServer Java Language_Server #2185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kessplas
wants to merge
5
commits into
master
Choose a base branch
from
kessplas/esdk-test-server
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7c2a240
feat: add the ESDK TestServer Java Language_Server
kessplas f42d4b7
chore(test-server): read commons coordinates from server-config.json
kessplas 76d3608
ci(test-server): add the cross-language TestServer workflow
kessplas ffe5e93
ci(test-server): run the TestServer through the shared commons workflow
kessplas d24adbb
chore: retrigger CI
kessplas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: ESDK TestServer (Java) | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "test-server/**" | ||
| - "src/**" | ||
| - "pom.xml" | ||
| - ".github/workflows/test-server.yml" | ||
| push: | ||
| branches: | ||
| - master | ||
| paths: | ||
| - "test-server/**" | ||
| - "src/**" | ||
| - "pom.xml" | ||
| - ".github/workflows/test-server.yml" | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| # The cross-language TestServer run, from the shared commons workflow. This | ||
| # checkout supplies the java server and library; every other server comes from | ||
| # its configured branch. Only the pairs involving java run; the full matrix | ||
| # runs in commons. repo-pat reads the private aws-crypto-tools-rust clones. | ||
| test-server: | ||
| name: TestServer | ||
| permissions: | ||
| contents: read | ||
| actions: read | ||
| id-token: write | ||
| uses: aws/aws-crypto-tools-commons/.github/workflows/esdk-test-server-reusable.yml@main | ||
| with: | ||
| focus: java | ||
| checkout-languages: java | ||
| secrets: | ||
| repo-pat: ${{ secrets.COMMONS_REPO_PAT }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # The Commons_Repository is cloned fresh at head on every run (Req 8.2/8.4); | ||
| # never commit the clone back into this Language_Repository. | ||
| .commons-clone/ | ||
|
|
||
| # Maven versions plugin backup poms produced by build-live-esdk (safety net; | ||
| # the recipe reverts the version, but leave these ignored just in case). | ||
| *.versionsBackup | ||
|
|
||
| # Integration test scratch output. | ||
| .it-tmp/ | ||
| # jqwik's local failure-sample database (developer-local, not shared). | ||
| **/.jqwik-database |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # ESDK TestServer integration (aws-crypto-tools-java Language_Repository) | ||
|
|
||
| This directory wires the live ESDK Java source into the cross-language | ||
| TestServer. It does **not** embed the TestServer; instead it clones the | ||
| `Commons_Repository` fresh at a branch head on every run and orchestrates the | ||
| TestServer against this repo's working tree as the live Java source. | ||
|
|
||
| ## `commons-source.json` — the single source of truth for commons coordinates | ||
|
|
||
| `commons-source.json` is the **Commons_Source_Config** (Requirement 8.2): the | ||
| one place in this Language_Repository that names the `Commons_Repository` | ||
| coordinates — its `name`, repository `url`, and the `branch` to clone at head: | ||
|
|
||
| ```json | ||
| { | ||
| "commonsRepository": { | ||
| "name": "aws-crypto-tools-commons", | ||
| "url": "git@github.com:aws/aws-crypto-tools-commons.git", | ||
| "branch": "kessplas/esdk-test-server" | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| Both the [`Makefile`](./Makefile) and the CI workflow | ||
| [`.github/workflows/esdk-test-server.yml`](../../.github/workflows/esdk-test-server.yml) | ||
| **read** these coordinates from this file (parsed with `python3` — no `jq` | ||
| dependency) rather than carrying their own hardcoded defaults, so the two never | ||
| drift apart. | ||
|
|
||
| - The Makefile exposes `COMMONS_REPO` / `COMMONS_BRANCH` whose **defaults** come | ||
| from this file; both stay overridable on the command line | ||
| (`make run COMMONS_BRANCH=some-branch`). | ||
| - The CI workflow resolves the branch from this file, unless a non-empty | ||
| `commons_branch` `workflow_dispatch`/`workflow_call` input overrides it. | ||
| - If this file is missing or unparseable, both fail fast with an error naming | ||
| it — it is the single source of truth, so its absence is a hard error. | ||
|
|
||
| ### Branch default note | ||
|
|
||
| The design default for `branch` is `main`. Until the ESDK TestServer merges to | ||
| commons `main`, this file pins the `kessplas/esdk-test-server` feature branch so | ||
| the flow works out of the box. **Once the TestServer merges to commons `main`, | ||
| flip `branch` back to `main` here** — no other file needs to change. | ||
|
|
||
| ## Common targets | ||
|
|
||
| Run `make help` for the full list and the resolved commons coordinates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| [ | ||
| "decrypt-accepts-out-of-order-frame-sequence", | ||
| "create-client-accepts-zero-max-encrypted-data-keys", | ||
| "encrypt-stream-ignores-plaintext-length-bound", | ||
| "encrypt-rejects-empty-encryption-context-value", | ||
| "encrypt-accepts-reserved-prefix-encryption-context-key", | ||
| "encryption-context-value-length-capped-at-32767" | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "supportedFeatures": [ | ||
| "streaming", | ||
| "MPL", | ||
| "hierarchical", | ||
| "raw-aes", | ||
| "raw-rsa", | ||
| "multi", | ||
| "aws-kms", | ||
| "aws-kms-multi", | ||
| "aws-kms-discovery", | ||
| "aws-kms-mrk", | ||
| "aws-kms-mrk-multi", | ||
| "aws-kms-mrk-discovery", | ||
| "aws-kms-rsa", | ||
| "required-encryption-context" | ||
| ], | ||
| "unsupportedFeatures": [ | ||
| "raw-ecdh", | ||
| "aws-kms-ecdh", | ||
| "caching" | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "commonsRepository": { | ||
| "name": "aws-crypto-tools-commons", | ||
| "url": "git@github.com:aws/aws-crypto-tools-commons.git", | ||
| "branch": "lucmcdon/esdk-test-server-all-languages" | ||
| }, | ||
| "product": "esdk" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Gradle | ||
| .gradle/ | ||
| build/ | ||
|
|
||
| # Smithy build output | ||
| smithyprojections/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,207 @@ | ||
| // Builds the Java Language_Server for the ESDK TestServer service over the | ||
| // rpcv2Cbor protocol. The server scaffolding (request decoding, response | ||
| // encoding, routing, error serialization) is generated from the single | ||
| // source-of-truth Smithy model hosted in the aws-crypto-tools-commons | ||
| // repository (esdk/test-server/model), supplied via the REQUIRED `modelDir` | ||
| // Gradle property, by the smithy-java `java-codegen` build plugin in SERVER | ||
| // mode (Requirement 1.7); only the operation handler bodies are hand-written. | ||
| // | ||
| // This repository carries NO copy of the model: the orchestrator always passes | ||
| // -PmodelDir=<resolved commons root>/esdk/test-server/model, and a developer | ||
| // running this module standalone passes it manually. | ||
| // | ||
| // The wire contract is identical to the one the single generated Java | ||
| // Test_Client (commons esdk/test-server/client-java) speaks, because both are | ||
| // generated from the same model with the same protocol declared once at the | ||
| // service level. | ||
|
|
||
| plugins { | ||
| `java-library` | ||
| // Runs the Smithy build (and thus the java-codegen plugin) during the | ||
| // Gradle build. Version comes from gradle.properties via settings. | ||
| id("software.amazon.smithy.gradle.smithy-base") | ||
| } | ||
|
|
||
| repositories { | ||
| // mavenLocal() is listed FIRST so that when the resolved ESDK Java library | ||
| // source has been installed to the local Maven repository (by the | ||
| // orchestrator's JavaLaunchPlan: mvn versions:set -> install -> revert | ||
| // under a distinct version), a matching | ||
| // `com.amazonaws:aws-encryption-sdk-java:<esdkVersion>` there is consumed | ||
| // as the LIVE source in place of the published GA artifact. The live flow | ||
| // installs a DISTINCT version (e.g. 3.0.2-LIVE-SNAPSHOT) and passes | ||
| // `-PesdkVersion=<that version>`, so head/default runs still resolve the | ||
| // published artifact from Maven Central below and only an explicit live | ||
| // run picks up the local build. | ||
| mavenLocal() | ||
| mavenCentral() | ||
| } | ||
|
|
||
| // smithy-java 1.x baselines on Java 21. Build with a JDK 21+ (set JAVA_HOME to a | ||
| // JDK 21 or newer when invoking Gradle). We intentionally do not pin a Java | ||
| // toolchain version here so the build uses whatever compatible JDK 21+ is | ||
| // configured for Gradle in the environment / CI, mirroring the client-java | ||
| // module. | ||
|
|
||
| val smithyJavaVersion: String by project | ||
| val smithyProtocolTraitsVersion: String by project | ||
| val esdkVersion: String by project | ||
| val materialProvidersVersion: String by project | ||
| val awsSdkKmsVersion: String by project | ||
| val jqwikVersion: String by project | ||
| val junitVersion: String by project | ||
|
|
||
| dependencies { | ||
| // --- Code generation (smithy build classpath only) --- | ||
| // The smithy-java code generation plugins, discovered by the smithyBuild | ||
| // task via SPI. | ||
| smithyBuild("software.amazon.smithy.java:codegen-plugin:$smithyJavaVersion") | ||
| // The rpcv2Cbor protocol trait definition must be resolvable while the | ||
| // model is built so `smithy.protocols#rpcv2Cbor` is understood by codegen. | ||
| smithyBuild("software.amazon.smithy:smithy-protocol-traits:$smithyProtocolTraitsVersion") | ||
|
|
||
| // --- Runtime dependencies of the generated server --- | ||
| // server-core is required by all generated smithy-java servers (routing, | ||
| // request/response plumbing, the operation/service abstractions). | ||
| api("software.amazon.smithy.java:server-core:$smithyJavaVersion") | ||
| // rpcv2Cbor server protocol implementation (request decoding / response and | ||
| // error encoding), discovered at runtime via SPI; this is the protocol | ||
| // declared once at the service level in the model. | ||
| api("software.amazon.smithy.java:server-rpcv2-cbor:$smithyJavaVersion") | ||
| // The rpcv2Cbor codec is used directly by ConfigMarshaller to round-trip the | ||
| // config shapes through the exact wire form the protocol uses. | ||
| implementation("software.amazon.smithy.java:cbor-codec:$smithyJavaVersion") | ||
| // The runnable ServerBootstrap main() needs the Netty HTTP server provider | ||
| // (the ServerProvider SPI implementation) on its runtime classpath so | ||
| // Server.builder() can bind a real HTTP endpoint. This is required only for | ||
| // the standalone launcher / manual two-step run, not for the generated | ||
| // server sources themselves. | ||
| runtimeOnly("software.amazon.smithy.java:server-netty:$smithyJavaVersion") | ||
|
|
||
| // --- Real ESDK Java delegation (Requirement 3.1, 4.2, 4.3) --- | ||
| // The CreateClient/Encrypt/Decrypt handlers delegate to the REAL AWS | ||
| // Encryption SDK for Java. For this pass we consume the published GA | ||
| // artifact from Maven Central (com.amazonaws:aws-encryption-sdk-java), which | ||
| // transitively pulls in the AWS Cryptographic Material Providers library | ||
| // (software.amazon.cryptography:aws-cryptographic-material-providers) used to | ||
| // construct keyrings and CMMs. This is aligned with the version the live | ||
| // product source declares (aws-crypto-tools-java/esdk/pom.xml -> 3.0.2). | ||
| // | ||
| // LIVE-SOURCE MODE (task 11): `esdkVersion` is overridable via | ||
| // `-PesdkVersion=<v>`. Default runs resolve the published GA artifact from | ||
| // Maven Central. A live run installs THIS repo's working tree to the local | ||
| // Maven repository under a distinct version (e.g. 3.0.2-LIVE-SNAPSHOT) and | ||
| // passes `-PesdkVersion=3.0.2-LIVE-SNAPSHOT`; combined with mavenLocal() | ||
| // above, the server then delegates to the LIVE ESDK Java build rather than | ||
| // the published artifact. The ESDK Java `mvn install` consumes the AWS | ||
| // Cryptographic Material Providers library as a published artifact (the | ||
| // esdk/pom.xml declares aws-cryptographic-material-providers:<v> from Maven | ||
| // Central), so no heavy Dafny/Smithy-Dafny transpile is required to build | ||
| // the live Java source. | ||
| implementation("com.amazonaws:aws-encryption-sdk-java:$esdkVersion") | ||
| // The handlers/config factory import the Material Providers keyring & CMM | ||
| // types directly, so declare the library explicitly (rather than leaning on | ||
| // the ESDK's transitive compile scope). Version aligned with the ESDK. | ||
| implementation("software.amazon.cryptography:aws-cryptographic-material-providers:$materialProvidersVersion") | ||
| // The AWS SDK KMS client. The Material Providers library above declares this | ||
| // only at `runtime` scope, but the EsdkClientFactory references KmsClient, | ||
| // EncryptionAlgorithmSpec, and GetPublicKeyRequest directly to fully wire the | ||
| // five KMS keyring variants (AwsKms/AwsKmsMrk/AwsKmsMultiKeyring/AwsKmsRsa/ | ||
| // AwsKmsDiscovery, task 15.3), so it must be on the compile classpath. Pinned | ||
| // to the version the Material Providers BOM (2.26.3) resolves. Construction of | ||
| // a KMS keyring performs no network call; only Encrypt/Decrypt reach AWS KMS. | ||
| implementation("software.amazon.awssdk:kms:$awsSdkKmsVersion") | ||
| // The hierarchical keyring's branch-key store reads from DynamoDB. | ||
| implementation("software.amazon.awssdk:dynamodb:$awsSdkKmsVersion") | ||
|
|
||
| // --- Test dependencies --- | ||
| // jqwik: the established Java property-based testing library used for the | ||
| // harness-logic property tests (do not hand-roll PBT). | ||
| testImplementation("net.jqwik:jqwik:$jqwikVersion") | ||
| testImplementation("org.junit.jupiter:junit-jupiter-api:$junitVersion") | ||
| testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:$junitVersion") | ||
| } | ||
|
|
||
| // The shared model is owned by the model/ package; this server only consumes | ||
| // it. Disable the formatter so building the server never rewrites the single | ||
| // source-of-truth model file (Requirement 1.1). | ||
| smithy { | ||
| format.set(false) | ||
| } | ||
|
|
||
| // Use the single source-of-truth model hosted in the Commons_Repository | ||
| // (Requirement 1.7) rather than a copy. The location is supplied via the | ||
| // REQUIRED `modelDir` Gradle property; fail fast with a clear message when it | ||
| // is absent so a bare `./gradlew build` cannot silently pick up a stale or | ||
| // wrong model. | ||
| val modelDir: String = providers.gradleProperty("modelDir").orNull | ||
| ?: throw GradleException( | ||
| "The Java Language_Server consumes the Smithy model from the commons repository: " + | ||
| "pass -PmodelDir=<abs path to the commons esdk/test-server/model>" | ||
| ) | ||
|
|
||
| sourceSets { | ||
| main { | ||
| smithy { | ||
| srcDir(modelDir) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Add the generated server sources/resources to the main sourceSet so they are | ||
| // compiled alongside the hand-written handlers. | ||
| afterEvaluate { | ||
| val serverPath = smithy.getPluginProjectionPath(smithy.sourceProjection.get(), "java-codegen").get() | ||
| sourceSets { | ||
| main { | ||
| java { | ||
| srcDir("$serverPath/java") | ||
| } | ||
| resources { | ||
| srcDir("$serverPath/resources") | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Ensure code generation runs before compilation / resource processing. | ||
| tasks.named("compileJava") { | ||
| dependsOn("smithyBuild") | ||
| } | ||
|
|
||
| tasks.named("processResources") { | ||
| dependsOn("smithyBuild") | ||
| } | ||
|
|
||
| tasks.withType<Test>().configureEach { | ||
| useJUnitPlatform { | ||
| // jqwik registers its own JUnit Platform engine; include it explicitly. | ||
| includeEngines("jqwik", "junit-jupiter") | ||
| } | ||
| } | ||
|
|
||
| // A minimal runnable launcher for the Java Language_Server (task 5 support, NOT | ||
| // the full orchestrator of task 7). Starts the smithy-java rpcv2Cbor HTTP server | ||
| // on a configurable port so a user can run a real over-HTTP round trip manually: | ||
| // | ||
| // Terminal 1 (start the server on port 8080): | ||
| // JAVA_HOME=<jdk21+> ./gradlew runServer | ||
| // # or choose a port: | ||
| // JAVA_HOME=<jdk21+> ./gradlew runServer --args="9090" | ||
| // # or: JAVA_HOME=<jdk21+> ./gradlew runServer -Pport=9090 | ||
| // | ||
| // Terminal 2 (point the Tests at it — from ../../tests): | ||
| // JAVA_HOME=<jdk21+> ./gradlew test -Desdk.testserver.endpoints=http://127.0.0.1:8080 | ||
| // | ||
| // The port may also be supplied via -Pport=<n>, the system property | ||
| // esdk.testserver.port, or the ESDK_TESTSERVER_PORT env var (see ServerBootstrap). | ||
| tasks.register<JavaExec>("runServer") { | ||
| group = "application" | ||
| description = "Start the Java Language_Server (rpcv2Cbor HTTP) on a configurable port." | ||
| mainClass.set("aws.cryptography.esdk.testserver.server.launcher.ServerBootstrap") | ||
| classpath = sourceSets["main"].runtimeClasspath | ||
| // Allow `-Pport=<n>` as a convenience in addition to CLI args / sys prop / env. | ||
| (project.findProperty("port") as String?)?.let { | ||
| systemProperty("esdk.testserver.port", it) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Versions for the Java Language_Server, kept in lockstep with the single | ||
| # generated Java Test_Client (../client-java) so the wire contract is identical | ||
| # on both ends. smithy-java 1.4.0 is the current stable release on Maven Central; | ||
| # the Smithy Gradle plugin (smithy-base) is versioned independently and is also | ||
| # at 1.4.0. smithyProtocolTraitsVersion matches the pin used by the model's own | ||
| # smithy-build.json so the rpcv2Cbor protocol trait resolves identically during | ||
| # code generation. | ||
| # | ||
| # The smithy-java codegen version and the smithy-java server runtime are kept in | ||
| # lockstep (both 1.4.0). | ||
| smithyGradleVersion=1.4.0 | ||
| smithyJavaVersion=1.4.0 | ||
| smithyProtocolTraitsVersion=1.58.0 | ||
|
|
||
| # The published AWS Encryption SDK for Java GA artifact, consumed from Maven | ||
| # Central for this pass to prove the harness end-to-end. Aligned with the | ||
| # version the live product source declares (aws-crypto-tools-java/esdk 3.0.2); | ||
| # it transitively brings in the AWS Cryptographic Material Providers library. | ||
| esdkVersion=3.0.2 | ||
|
|
||
| # The AWS Cryptographic Material Providers library (keyrings & CMMs), aligned | ||
| # with the version the ESDK 3.0.2 product source declares. | ||
| materialProvidersVersion=1.7.0 | ||
|
|
||
| # The AWS SDK for Java v2 KMS client version. The Material Providers library | ||
| # 1.7.0 declares the AWS SDK KMS dependency only at `runtime` scope (via the | ||
| # `software.amazon.awssdk:bom` 2.26.3), so the EsdkClientFactory — which now | ||
| # references `KmsClient`, `EncryptionAlgorithmSpec`, and `GetPublicKeyRequest` | ||
| # directly to fully wire the five KMS keyring variants (task 15.3) — declares | ||
| # the KMS SDK explicitly on the compile classpath, pinned to the same version | ||
| # the Material Providers BOM resolves so the two stay in lockstep. | ||
| awsSdkKmsVersion=2.26.3 | ||
|
|
||
| # jqwik is the established Java property-based testing library used for the | ||
| # harness-logic property tests (design Testing Strategy). JUnit 5 platform hosts | ||
| # both jqwik and the example-based unit tests. | ||
| jqwikVersion=1.9.2 | ||
| junitVersion=5.11.3 | ||
|
|
||
| # Run the Smithy CLI in a forked process to isolate its classloader from Gradle. | ||
| org.gradle.jvmargs=-Xmx2g |
|
josecorella marked this conversation as resolved.
|
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsure why this is the case