ci: skip integration/otel tests for external pull requests - #728
Merged
Merged
Conversation
hln33
marked this pull request as ready for review
September 15, 2026 17:29
hln33
force-pushed
the
main
branch
3 times, most recently
from
September 17, 2026 16:38
18ddf77 to
5993b13
Compare
wangyb-A
approved these changes
Sep 18, 2026
This was referenced Sep 23, 2026
hln33
added a commit
to aws/aws-durable-execution-sdk-js
that referenced
this pull request
Sep 24, 2026
Issue #, if available: N/A ## Description of changes Skip both conformance workflows for pull requests from forks and from Dependabot. `conformance-tests.yml` and `otel-conformance-tests.yml` are triggered directly by `pull_request` (not called from `build.yml`) and both consume secrets — `TEST_ROLE_ARN`, `TEST_LAMBDA_EXECUTION_ROLE_ARN`, and the OTel backend tokens. A fork PR that touches `packages/aws-durable-execution-sdk-js/**` therefore starts a run that cannot authenticate and fails on an empty secret. `build.yml` already guards `integration-tests` and `capacity-provider-tests` the same way (`build.yml:143-146`, `:161-164`); this extends that to the two conformance workflows, using the wording the Python SDK settled on in aws/aws-durable-execution-sdk-python#728 so the repos read identically. The guard goes on the root job of each workflow — `discover_suites` and `opentelemetry`. The conformance matrix has `needs: discover_suites`, so the skip cascades without a second copy of the condition. ```yaml if: github.event_name != 'pull_request' || (github.actor != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) ``` `push` to main and `workflow_dispatch` runs are unaffected by the first clause, and the condition is a no-op for same-repo branches, so maintainer PRs keep full conformance signal. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.