ci: pass --url, required by server 2.4.0 - #13
Merged
Conversation
The server exits at boot without --url as of authorizerdev/authorizer#764. CI pins 2.4.0-rc.16, which predates the requirement, so this is a no-op today and stops the job breaking when the pin moves to stable. Port mapping is fixed 8080:8080, so the container's own address and the address the tests dial are the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
authorizerdev/authorizer#764 made
--urlmandatory — the server exits at boot without it. The CI job starts Authorizer viadocker runwith no--url, so it will fail to start once the image pin moves to 2.4.0 stable.The pin is currently
2.4.0-rc.16, which predates the requirement, so this change is a no-op today and prevents a breakage later rather than fixing a current failure.Why this value
The run maps ports
8080:8080, so the container's own address and the address the tests dial are identical —http://localhost:8080is correct for both the server's self-reference (email links, JWTiss) and the health check.ci.ymlvalidated as YAML.