Skip to content

851 Issue fix (with has_synthetic_create?) - #918

Open
Mckay-Hinds wants to merge 2 commits into
ash-project:mainfrom
Mckay-Hinds:fix-851-manual-create-migrations
Open

Mckay-Hinds wants to merge 2 commits into
ash-project:mainfrom
Mckay-Hinds:fix-851-manual-create-migrations

Conversation

@Mckay-Hinds

@Mckay-Hinds Mckay-Hinds commented Nov 5, 2026 •

Copy link
Copy Markdown

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

Comment thread lib/data_layer.ex
doc:
"Whether or not to include this resource in the generated migrations with `mix ash.generate_migrations`"
],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some strange formatting/spacing here, and also in the other file a bunch of changes that seem unrelated to the actual change. Mind formatting/checking that out?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, for sure. I had accidentally used the command mix format instead of mix test so I had to go and undo a lot of stuff so that could be what had happened.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some unintended Windows line-ending changes that were causing unrelated lines to appear in the diff. I was able to go ahead and clean em up so they shouldn't be a problem. Let me know if there was anything I missed or that you wanted me to take a closer look at as well :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just approved the GH actions to run but I think formatter will fail here due to extra lines around this keyword list item.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants