Repository navigation
fix: Use the configured port in the timestamptz test repo - #917
Merged
zachdaniel merged 1 commit intoNov 3, 2026
Merged
Conversation
jechol
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
zachdaniel
approved these changes
Nov 3, 2026
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running the test suite against an isolated PostgreSQL instance on a non-default port, the three
timestamptz datetime toggletests failed to connect.TestReporespectsPG_PORT, butTimestamptzToggleRepoomits the port and falls back to 5432. ReuseAshPostgres.TestRepo.config()[:port]so both repos connect to the configured instance.Verified that the three affected tests pass against PostgreSQL 17 on a non-default port.
Contributor checklist
Leave anything that you believe does not apply unchecked.