Repository navigation
fix: include manual create actions in has_create_action?/1 - #913
Closed
hoanle0126 wants to merge 1 commit into
Closed
hoanle0126 wants to merge 1 commit into
hoanle0126 wants to merge 1 commit into
Conversation
Contributor
|
I don't think this is right. It's not a given that a manual create action interacts with the data layer. See my comment on that issue:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_create_action?/1inAshPostgres.MigrationGeneratorpreviously excluded create actions that setmanual. Because extensions likeAshEventswrap resource create actions as manual actions, resources usingAshEventsreportedhas_create_action: false, causingcount_with_createto be0when multiple evented resources share a table and marking subtype-specificallow_nil?: falsecolumns asnull: falsein generated migrations.Since manual create actions still insert rows into the underlying table, this updates
has_create_action?/1to count all:createactions regardless of whethermanualis set.Closes #851
Contributor Checklist