Repository navigation
fix: restore columns before custom indexes on rollback - #912
Merged
zachdaniel merged 1 commit intoOct 29, 2026
Merged
Conversation
Contributor
|
LGTM. Please LMK when its not a draft as GH won't send me a notification for that. |
2 tasks done
jeffhuen
marked this pull request as ready for review
October 29, 2026 00:41
Contributor
Author
|
Ready for review now, @zachdaniel. The patch is unchanged at 642d848. |
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a column and its custom index can generate a rollback that recreates the index before the column exists.
Make
RemoveAttributedepend on index removal so rollback restores the column first. Normalize string and atom field names with the existing helper so their dependency keys match, including during renames. SQL-expression dependencies remain unsupported.Add regressions for operation ordering and generated
upanddownmigrations. The generator regression fails before the fix and passes afterward.Related to #159.