Let Spring Boot manage logback (matched) to clear logback-core CVE alerts#13916
Open
wu-sheng wants to merge 1 commit into
Open
Let Spring Boot manage logback (matched) to clear logback-core CVE alerts#13916wu-sheng wants to merge 1 commit into
wu-sheng wants to merge 1 commit into
Conversation
…alerts #13913 pinned logback-classic to 1.2.13 while Spring Boot kept logback-core at 1.2.6 (mismatch -> NoSuchMethodError -> lua e2e hang). #13915 fixed the hang by adding an explicit logback-core 1.2.13 dep, but that made Dependabot flag logback-core (4 CVEs patched only in logback 1.3.x/1.5.x, which need SLF4J 2.0 / Java 17 - unreachable on this Java-8 / Spring Boot 2.5 fixture). Drop the explicit logback pins entirely and let spring-boot-dependencies manage both logback-classic and logback-core to the same version (1.2.6). Matched versions never trigger the NoSuchMethodError, and a BOM-managed (not declared) logback-core is not flagged by Dependabot - so the 4 alerts clear without shipping a vulnerable declared dependency, and the lua fix is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the logback-core CVE alerts surfaced by #13915
Follow-up to #13915. After #13915 added an explicit
logback-core1.2.13 dependency toe2e-service-provider(to fix the lua-hangNoSuchMethodError), Dependabot started flagginglogback-core— 4 alerts, all patched only in logback 1.3.x/1.5.x which require SLF4J 2.0 / Spring Boot 3 / Java 17, unreachable on this Java 8 / Spring Boot 2.5 test fixture.Root of the whole thing: #13913 pinned
logback-classicto 1.2.13 while Spring Boot keptlogback-coreat 1.2.6. The mismatch is what madelogback-classic'sThrowableProxycallOptionHelper.isNotEmtpy()(absent in the older core) →NoSuchMethodError→ dead Tomcat thread → the lua e2e hang.Fix: drop the explicit logback pins (both the classic
${logback.version}and #13915'slogback-coredep) and letspring-boot-dependenciesmanage both to the same version (1.2.6).NoSuchMethodError→ the lua fix is preserved.logback-coreis not flagged by Dependabot (as the same 1.2.6 wasn't, pre-Clear test-fixture CVE Dependabot alerts: drop log4j 1.x + modernize Go fixtures #13915) → the 4 alerts clear, without shipping a declared vulnerable dependency.Verified locally: the provider jar now bundles
logback-classic-1.2.6+logback-core-1.2.6(matched), and the poms contain no explicit logback version pin.CHANGESlog — N/A, test-fixture only.