Repository navigation
Conversation
adoroszlai
marked this pull request as ready for review
November 7, 2026 09:53
Contributor
|
CLI shows the missing |
Contributor
Author
|
@adoroszlai thanks!! |
rich7420
marked this pull request as draft
November 9, 2026 08:54
Contributor
Author
|
Moving this to draft for now. HDDS-17478 pulls the shared chunk and trailer parsing into a common base class, so I'd like to land that first and then move these error changes there. |
# Conflicts: # hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/SignedChunksInputStream.java # hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/UnsignedChunksInputStream.java # hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/TestSignedChunksInputStream.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The S3 Gateway parses signed chunk sizes as
longand maps overflow toInvalidRequest, avoiding uncaughtNumberFormatException. Parser-detected truncation returnsIncompleteBody, and malformed trailers returnMalformedTrailerError. Signature/checksum error precedence and commit guards are preserved; shared Content-Length mismatch handling remains unchanged.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17476
How was this patch tested?
NumberFormatExceptionerrors); restoring the fix passed.checkstyle.shand module PMD passed. The configured SpotBugs 3.1.12.2 cannot analyze Java 17 class files; SpotBugs 4.8.6.8 analysis of the changed production classes reported no new findings against the base and retained one existing constructor warning.19dd8238e0(113 jobs passed, 2 skipped). S3 Gateway unit tests passed 2065 cases and S3 integration tests passed 383 cases, with no failures, errors or skips in either suite.