HDDS-16244. Remove redundant RPC metadata from SCMSecurityProtocol - #11079
Open
echonesis wants to merge 1 commit into
Open
HDDS-16244. Remove redundant RPC metadata from SCMSecurityProtocol#11079echonesis wants to merge 1 commit into
echonesis wants to merge 1 commit into
Conversation
chihsuan
approved these changes
Aug 22, 2026
chihsuan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch! @echonesis +1 LGTM
cc @chungen0126
szetszwo
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SCMSecurityProtocolduplicated the protocol version and Kerberos metadata already defined bySCMSecurityProtocolPB, which is the interface used by Hadoop RPC.This PR:
versionIDand@KerberosInfoannotation fromSCMSecurityProtocol;SCMSecurityProtocolPB;This consolidates the RPC metadata in the protocol interface where it is consumed and prevents the duplicated definitions from diverging.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16244
How was this patch tested?
Local Test
GitHub Actions CI: https://github.com/echonesis/ozone/actions/runs/32463288850
Generated-by: Codex (GPT-5)