HDDS-16214. Avoid per-group list copies in KeyManagerImpl read paths - #11078
Open
dino2895 wants to merge 1 commit into
Open
HDDS-16214. Avoid per-group list copies in KeyManagerImpl read paths#11078dino2895 wants to merge 1 commit into
dino2895 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes KeyManagerImpl read paths by avoiding temporary flattened location-list copies.
Changes:
- Iterates grouped locations directly for block token generation and datanode sorting.
- Uses nested traversal for container ID extraction.
- Preserves existing behavior.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid creating flattened location list copies in the following
KeyManagerImplread paths:These paths now iterate
getLocationLists()directly while preserving the existing behavior.What is the link to the Apache Jira?
https://issues.apache.org/jira/browse/HDDS-16214
How was this patch tested?
mvn -pl :ozone-manager -am clean test -Dtest=TestKeyManagerUnit#listStatus -Dsurefire.failIfNoSpecifiedTests=false -DskipShade -DskipRecon -DskipDocs./hadoop-ozone/dev-support/checks/checkstyle.sh