HDDS-16025. Allow old clients to start finalization on a new server. - #11074
Draft
errose28 wants to merge 3 commits into
Draft
HDDS-16025. Allow old clients to start finalization on a new server.#11074errose28 wants to merge 3 commits into
errose28 wants to merge 3 commits into
Conversation
sodonnel
approved these changes
Aug 21, 2026
sodonnel
left a comment
Contributor
There was a problem hiding this comment.
I believe this looks good. As stated in the description much of the new line count is due to tests and lifting some existing code into a new shared base class, so the change isn't as large as it first appears.
Contributor
Author
|
Unfortunately this broke something at the acceptance level that I need to figure out: https://github.com/errose28/ozone/actions/runs/32425781316/job/96617583956 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
An old client's finalize upgrade command to OM should still start the finalization process. The server will need to return a different response to the old client and redirect to the new finalization flow internally. This has already been handled on SCM in HDDS-15609.
org.apache.hadoop.hdds.scm.client.ScmClient#finalizeUpgradeleft over from an earlier implementation on the feature branch where finalization started from client to SCM.The high line count is due to the new integration test and movement of existing code in the finalize requests. Most changes do not introduce new functionality.
What is the link to the Apache JIRA
HDDS-16025
How was this patch tested?