HDDS-15689. Compare MD5Hash directly in ScmInvokerCodeGenerator#10618
Merged
Conversation
Russole
approved these changes
Jun 26, 2026
Russole
left a comment
Contributor
There was a problem hiding this comment.
Thanks @adoroszlai for working on this. LGTM!
priyeshkaratha
approved these changes
Jun 26, 2026
priyeshkaratha
left a comment
Contributor
There was a problem hiding this comment.
Thanks @adoroszlai for the patch. Changes LGTM
szetszwo
approved these changes
Jun 26, 2026
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
+1 the change looks good. Thanks for fixing this!
Contributor
Author
|
Thanks @priyeshkaratha, @Russole, @szetszwo for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ozone/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/invoker/ScmInvokerCodeGenerator.java
Lines 643 to 645 in 29b2ad5
getDigest()returnsbyte[]in Ratis 3.2.1, butByteBufferin 3.2.2 (RATIS-2361), resulting in compile error:MD5Hash#equalsis based ondigestinternally, so we can makeScmInvokerCodeGeneratorwork with both versions of Ratis by checking equality ofMD5Hashitself.https://issues.apache.org/jira/browse/HDDS-15689
How was this patch tested?
Build, checkstyle,
TestScmInvokerCodeGeneratorBuild with Ratis 3.2.2:
https://github.com/adoroszlai/ozone/actions/runs/28229850840/job/83631071973