include/pthread: add wait_count to PTHREAD_COND_INITIALIZER#19147
Closed
Zepp-Hanzj wants to merge 1 commit into
Closed
include/pthread: add wait_count to PTHREAD_COND_INITIALIZER#19147Zepp-Hanzj wants to merge 1 commit into
Zepp-Hanzj wants to merge 1 commit into
Conversation
PTHREAD_COND_INITIALIZER was missing the initialization of the wait_count field in struct pthread_cond_s, causing a -Wmissing-field-initializers warning when statically initializing condition variables. Fixes apache#19108 Signed-off-by: hanzhijian <hanzhijian@zepp.com>
Contributor
|
@Zepp-Hanzj already fixed here: #19109 |
Contributor
Author
|
Got it, thanks for pointing that out! I see that #19109 already addressed this. Closing this PR as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PTHREAD_COND_INITIALIZERwas missing the initialization of thewait_countfield instruct pthread_cond_s, causing a-Wmissing-field-initializerswarning when statically initializing condition variables.Before
After
Fixes #19108
Impact
Eliminates
-Wmissing-field-initializerswarning forPTHREAD_COND_INITIALIZER. No functional change since C guarantees zero-initialization for missing fields in partial initializers, but the explicit initialization is cleaner and silences the warning.Testing
Verified with
grepthat all fields ofstruct pthread_cond_sare now covered by the initializer.