NIFI-15911 Add Web Client Service for Snowflake Ingest Service - #11369
Merged
Conversation
6 tasks
pvillard31
reviewed
Jun 25, 2026
| try { | ||
| return objectMapper.readValue(responseBodyStream, InsertReport.class); | ||
| } catch (final JsonProcessingException e) { | ||
| final byte[] responseBodyBytes = responseBodyStream.readAllBytes(); |
Contributor
There was a problem hiding this comment.
When readValue fails to parse, has the response stream already been consumed, so the body included in the error message would be empty?
Contributor
Author
There was a problem hiding this comment.
Good catch, thanks! I pushed an update to read the response body as a string regardless of status code.
pvillard31
approved these changes
Jun 25, 2026
pvillard31
left a comment
pvillard31
left a comment
Contributor
There was a problem hiding this comment.
Thanks @exceptionfactory - LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15911 Adds a
Web Client Service Providerproperty to theStandardSnowflakeIngestManagerProviderServicein order to support Proxy Servers and other configuration features for HTTP operations.The additional property is required, and property migration methods add a default
StandardWebClientServiceProviderimplementation when the Snowflake Ingest Manager Provider Service does not have one configured. This enables upgrades to existing flows without requiring manual configuration.The implementation changes replace direct use of the Java
HttpClientwith the equivalentWebClientServicemethods defined in thenifi-web-client-apimodule. Updated unit tests exercise the property migration behavior.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation