feat(runtime-host): add ACP connection ownership and sign-in state - #5224
Draft
Sun-GLiang wants to merge 6 commits into
Draft
feat(runtime-host): add ACP connection ownership and sign-in state#5224Sun-GLiang wants to merge 6 commits into
Sun-GLiang wants to merge 6 commits into
Conversation
Retain ACP connection ownership across operations and failed cleanup, pass admitted proxy settings to the agent, and expose Host-scoped authentication evidence through Desktop Settings. Refs apache#5103 Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
Sun-GLiang
force-pushed
the
feat/antigravity-acp-pr2
branch
from
September 12, 2026 07:29
6a6b3be to
84bbed6
Compare
Add external executor identity, retained ACP task backend and initial Composer integration. Preserve assistant history without a native model route. Desktop acceptance and renderer architecture remediation remain pending. Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
配置外部 Agent, remain fully visible without horizontal scrolling.session/new, prompt, transport, and provider-execution failures as explicit terminal events with stage-specific reasons plus bounded, secret-redacted diagnostics.NO_PROXYspellings withlocalhost,127.0.0.1, and::1without discarding the user's existing bypass list.session/new, prompting, permission settlement, cancellation races, attachment rejection, proxy inheritance, typed failure finalization, and AppShell architecture boundaries.Refs #5103
Verification
Baseline validation completed at
2a49069dd:git diff --checkFollow-up validation at
e79f98799: the Runtime Host build passed; the 3 new initialize/session_new/prompt diagnostic regressions passed; the related ACP suites passed 29/29; Biome andgit diff --checkpassed.Follow-up validation at
6d8cd7cdf:git diff --checkpassed.client-capability-session-scopesuite and are unrelated to ACP; every affected ACP suite is green.Desktop acceptance
Re-ran the production renderer in Electron with official Antigravity ACP 1.1.1 and the normal Maka Dev profile. The final verification launch did not inject
HTTP_PROXY,HTTPS_PROXY, orALL_PROXYinto the Desktop process. The macOS system proxy remained enabled, including its loopback SOCKS endpoint; the ACP child inherited external routing while bypassing the proxy for its own localhost harness.clientWidth === scrollWidth === 808; horizontal overflow was hidden and all localized labels were visible.pwdcommand, theAntigravity · ACPrequester, and Allow/Deny actions.pwdandclient_view_fileappeared in arrival order and the final answer contained the expected working directory and the first line ofREADME.md.sleep 30command produced an interrupted tool/turn state instead of waiting for natural completion.session/newand failed because official ACP 1.1.1 does not bundlepython-socks. After the local bypass fix, the same no-manual-proxy launch completed a real prompt in 9 seconds and persistedcompleted/end_turn.acp_setup_authentication_failed, rather than replacing it withmissing_terminal_event. After restoring cached Google authentication, a final live prompt again completed in 9 seconds withcompleted/end_turn.Agent execution error:now produces the structuredacp_agent_execution_failedevent before terminal completion, so the renderer can show diagnostic details instead of “无可用诊断详情”; this boundary is covered by the new backend regression test.UI acceptance screenshots
The screenshots above are GitHub user attachments referenced only from this PR description; no image file is tracked by the branch.
See the sanitized verification record for the detailed validation history and evidence boundaries.
Review focus
PR1 #5164 was squash-merged as
41da161d6d2aa53c82b2ccf261e519cf09a09b7d; this PR is based on that merge commit and advances the protocol epoch to 147 for ACP execution identity.Please focus review on executor identity and strict decoding, process ownership, live/history-only availability, transcript preservation without
modelId, file containment, permission settlement, cancellation races, mixed tool-result ordering, local proxy bypass, typed ACP failure finalization, and the Composer executor/model state machine.The PR remains in Draft while human review and GitHub CI are pending. The current branch also requires conflict resolution against the latest target branch before CI can run.
AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex contributed implementation, tests, evidence documentation, Desktop acceptance, and PR preparation. Independent human review remains pending.
Checklist
Does this PR entail a change in behavior?