Skip to content

fix(desktop): add HTML artifact Finder fallback - #5218

Open
Dante-dan wants to merge 2 commits into
apache:mainfrom
Dante-dan:fix/5215-html-artifact-finder-fallback
Open

fix(desktop): add HTML artifact Finder fallback#5218
Dante-dan wants to merge 2 commits into
apache:mainfrom
Dante-dan:fix/5215-html-artifact-finder-fallback

Conversation

@Dante-dan

Copy link
Copy Markdown
Contributor

Summary

  • Add the existing localized Show in Finder action to the HTML artifact read-failure banner while leaving successful sandboxed previews unchanged.
  • Reuse the Artifact Pane's existing openPath(sessionId, artifactId) route, so materialization and path validation remain in the main process.
  • Add a focused rendered-failure regression and strengthen the desktop service adapter assertion.

PR #5216 independently proposed wiring the same failure-state callback. This version keeps the issue's failure-only scope and adds regression coverage without changing successful HTML artifact opening.

Fixes #5215

Verification

  • Desktop workspace dependency build passed.
  • Desktop build:main, typecheck, and renderer production build passed.
  • 27 focused HTML fallback, adapter, artifact IPC, open-path guard, and external-link guard tests passed.
  • Biome passed on all four changed files.
  • git diff --check origin/main...HEAD passed.
  • Independent acceptance reran the main-process TypeScript compile and three focused suites: 15 passed, 0 failed.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex implemented and tested the focused UI fallback; a separate Codex acceptance pass reviewed the diff and reran targeted validation.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@github-actions github-actions Bot added the effort/M Under 500 readable lines label Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/M Under 500 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(desktop): offer Finder fallback when HTML artifact preview cannot be read

1 participant