fix(ci): widen the locale hygiene gate to its blind spots - #5180
Open
orangeCatDeveloper wants to merge 1 commit into
Open
fix(ci): widen the locale hygiene gate to its blind spots#5180orangeCatDeveloper wants to merge 1 commit into
orangeCatDeveloper wants to merge 1 commit into
Conversation
Locale shortcuts in Runtime Host copy and bot error handling could silently select the wrong language, while multiline native dialogs escaped the source gate. Use typed catalogs and explicit locale-aware rendering, then scan complete source files so these patterns cannot return. Generated-by: Claude Code Generated-by: Codex
orangeCatDeveloper
force-pushed
the
fix/locale-hygiene-coverage
branch
from
September 13, 2026 03:00
ce47b7e to
a965d52
Compare
orangeCatDeveloper
marked this pull request as ready for review
September 13, 2026 04:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2672
Summary
Runtime Host handoff treated every non-English locale as Chinese, while classified bot failures switched a Chinese-only surface to English. Multiline native-dialog literals also escaped the locale hygiene gate.
The live shortcuts now use a typed catalog or an explicit surface locale. The ratchet also scans Runtime Host and complete source files, rejecting these shortcuts and literal native-dialog copy without requiring historical cleanup.
Verification
Known live wrong-language shortcuts: 2/2 before → 0/2 after.
Before
After
The bot regression test renders the classified timeout in the surface locale:
The native-dialog rule is intentionally source-based and install-free. It covers inline
showOpenDialogandshowSaveDialogstring literals within 400 characters of the call; computed option objects remain outside its boundary.AI use
Select exactly one:
Tool(s) and scope: Claude Code and Codex — identified and repaired the locale shortcuts, extended the hygiene gate and tests, and updated the verification evidence. The commit carries the corresponding
Generated-bytrailers.Checklist
Does this PR entail a change in behavior?