perf(arrow): build repeated boolean columns with BooleanBuffer - #3178
Open
anoopj wants to merge 1 commit into
Open
perf(arrow): build repeated boolean columns with BooleanBuffer#3178anoopj wants to merge 1 commit into
anoopj wants to merge 1 commit into
Conversation
create_primitive_array_repeated built a constant boolean column with BooleanArray::from(vec![*value; n]), which allocates an n-byte Vec<bool> and then bit-packs it. Set or clear the bits directly with BooleanBuffer::new_set / new_unset instead. The sibling string and binary arms already skip the throwaway Vec via from_iter_values, so this just brings the bool arm in line. Same output, no nulls. This path materializes constant columns (partition values, defaults, metadata) on read, and boolean constants are uncommon, so it's a minor win.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
This is similar to #3177 but for constant columns.
create_primitive_array_repeated built a constant boolean column with BooleanArray::from(vec![*value; n]), which allocates an n-byte Vec and then bit-packs it. Set or clear the bits directly with BooleanBuffer::new_set / new_unset instead. The sibling string and binary arms already skip the throwaway Vec via from_iter_values, so this just brings the bool arm in line.
Same output, no nulls. This path materializes constant columns (partition values, defaults, metadata) on read, and boolean constants are uncommon, so it's a minor win.
Are these changes tested?
Covered by existing tests