feat(encryption): [2/N] Add standard key metadata - #3948
Open
xanderbailey wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
approved these changes
Sep 11, 2026
kevinjqliu
left a comment
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
LGTM
i pushed a change to redact encryption_key in repr
6f6ceaa
Comment on lines
+24
to
+26
| from pyiceberg.avro.decoder import new_decoder | ||
| from pyiceberg.avro.encoder import BinaryEncoder | ||
| from pyiceberg.avro.resolver import construct_reader, construct_writer |
Contributor
There was a problem hiding this comment.
BTW we want to rip out the current pyiceberg avro reader (which is written with cython) and replace with rust's avro reader. maybe this would be a good integration point 😄
kevinjqliu
enabled auto-merge
September 11, 2026 21:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python version of
StandardKeyMetadatadirect port of the logic added in https://github.com/apache/iceberg-rust/pull/2340/changesRationale for this change
Are these changes tested?
Are there any user-facing changes?