[MINOR] remove unused folly header in cpp/core/jni/JniCommon.cc - #12547
Merged
taiyang-li merged 1 commit intoAug 3, 2026
Conversation
liuneng1994
force-pushed
the
minor/remove_unused_folly_header
branch
from
July 20, 2026 05:36
bfe2c0a to
aaddcd9
Compare
Contributor
|
@jackylee-ch can you help review it, thanks! |
taiyang-li
pushed a commit
to taiyang-li/incubator-gluten
that referenced
this pull request
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Remove the unused
folly/system/ThreadName.hinclude fromcpp/core/jni/JniCommon.cc.cpp/core/CMakeLists.txtdoes not declare a Folly dependency, so including Folly headers fromcpp/coreis unsafe.How was this patch tested?
Manually compiled successfully.
Was this patch authored or co-authored using generative AI tooling?
No