[GLUTEN-12535][CORE] Support backend-specific JNI input adapters - #12535
Merged
taiyang-li merged 5 commits intoJul 24, 2026
Conversation
taiyang-li
reviewed
Jul 16, 2026
taiyang-li
reviewed
Jul 16, 2026
taiyang-li
reviewed
Jul 16, 2026
wangxinshuo-bolt
force-pushed
the
pr/core-jni-backend-adapters
branch
from
July 16, 2026 09:30
bee9bdd to
c436dce
Compare
wangxinshuo-bolt
marked this pull request as ready for review
July 16, 2026 12:43
taiyang-li
reviewed
Jul 21, 2026
Contributor
Author
|
@jackylee-ch Can you review this PR? |
Contributor
Member
|
hi @wangxinshuo-bolt is this also part of refactor work in #12456? |
Comment on lines
+70
to
+74
| std::unique_ptr<gluten::ColumnarBatchIterator> gluten::Runtime::createJniInputIterator( | ||
| const JniInputIteratorContext& context) { | ||
| return std::make_unique<JniColumnarBatchIterator>( | ||
| context.env, context.jColumnarBatchIterator, this, context.iteratorIndex); | ||
| } |
Member
There was a problem hiding this comment.
Should this be defined in Runtime.cc?
| return dumper_.get(); | ||
| } | ||
|
|
||
| virtual std::unique_ptr<ColumnarBatchIterator> createJniInputIterator(const JniInputIteratorContext& context); |
Member
There was a problem hiding this comment.
JniInputIteratorContext::env is of type JNIEnv* which requires jni.h, while the Runtime API is currently isolated from the JNI layer. Does it look like a design issue in the PR?
marin-ma
reviewed
Jul 22, 2026
|
|
||
| namespace gluten { | ||
|
|
||
| std::shared_ptr<StreamReader> makeShuffleStreamReader(JNIEnv* env, jobject jShuffleStreamReader) { |
Contributor
There was a problem hiding this comment.
We don't need to keep ShuffleStreamReader private. Would it make sense to move ShuffleStreamReader into JniCommon.h?
Contributor
Author
Yes |
marin-ma
reviewed
Jul 23, 2026
| } | ||
| std::shared_ptr<arrow::io::InputStream> in = std::make_shared<JavaInputStreamAdaptor>(env, pool, jniIn); | ||
| return in; | ||
| ShuffleStreamReader::ShuffleStreamReader(JNIEnv* env, jobject reader) { |
Contributor
There was a problem hiding this comment.
The implementation should be placed in JniCommon.cc
Contributor
Author
There was a problem hiding this comment.
The implementation should be placed in
JniCommon.cc
ok. I will fix it.
wangxinshuo-bolt
changed the title
wangxinshuo-bolt
changed the title
wangxinshuo-bolt
changed the title
marin-ma
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR provides backend-extensible JNI input adapters in Core as part of #12456.
The implementation:
JniInputIteratorFactoryregistry keyed by runtime kind.JniColumnarBatchIteratoras the default when no backend-specific factory is registered.ShuffleStreamReaderand Java input-stream adapter inJniCommon.JniCommonState.Backends can register their own JNI input iterator factory while continuing to use the common plan-evaluation and shuffle-stream interfaces.
How was this patch tested?
libgluten.so.Was this patch authored or co-authored using generative AI tooling?
Yes.
Generated-by: Codex GPT-5
Related issue: #12535