perf: optimize compatible mode read performance#3743
Open
chaokunyang wants to merge 35 commits into
Open
Conversation
pandalee99
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Compatible-mode xlang reads spend too much time in generic matched-field handling: exact schema matches can still carry compatible metadata, scalar widening can redispatch through generic converters, and regenerated serializers can keep extra matched-id dispatch in their hot paths. The benchmark matrix also lacked a focused schema-mismatch mode for measuring compatible-read behavior across runtimes.
What does this PR do?
FORY_BENCH_SCHEMA_MISMATCH=1, including v1-to-v2 int32-to-int64 compatible-read cases.Related issues
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
No public API or binary protocol compatibility change is intended. The visible change is benchmark-only documentation and runner support for schema-mismatch compatible-read measurements.
Benchmark
Adds schema-mismatch benchmark mode to the language benchmark runners. Run with
FORY_BENCH_SCHEMA_MISMATCH=1and--serializer foryto measure compatible-read deserialization where v1 benchmark payloads are read by v2 schemas using the same Fory type IDs and one widened int32-to-int64 field.