Skip to content

fix: correct typo in grpc_contrib_version property name - #16402

Open
lxcxjxhx wants to merge 1 commit into
apache:3.3from
lxcxjxhx:fix/bom-property-typo
Open

fix: correct typo in grpc_contrib_version property name#16402
lxcxjxhx wants to merge 1 commit into
apache:3.3from
lxcxjxhx:fix/bom-property-typo

Conversation

@lxcxjxhx

Copy link
Copy Markdown

Description

Fix a typo in the BOM property name: \grpc_contrib_verdion\ should be \grpc_contrib_version.

Changes

  • File: \dubbo-dependencies-bom/pom.xml\
    • Line 146: Changed property definition from <grpc_contrib_verdion>\ to <grpc_contrib_version>\
    • Line 914: Updated property reference from \\ to \\

Motivation

The property name contains a typo ('verdion' instead of 'version'). While this does not affect functionality (the property is used consistently), correcting it improves code readability and maintainability.

Testing

  • Local environment limitations: Windows environment with long path issues prevents full Maven build
  • This is a simple typo fix that maintains consistency between property definition and usage
  • Relying on CI/CD automated testing for validation

Apology

I apologize for any inconvenience caused by previous low-quality PRs. This fix is focused, minimal, and addresses a genuine typo in the codebase.

- Change 'grpc_contrib_verdion' to 'grpc_contrib_version'
- Update property definition and reference in dubbo-dependencies-bom/pom.xml
- This is a simple typo fix that does not affect functionality
@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.88%. Comparing base (3a30432) to head (830b6a1).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #16402      +/-   ##
============================================
+ Coverage     60.87%   60.88%   +0.01%     
+ Complexity    11766    11764       -2     
============================================
  Files          1953     1953              
  Lines         89273    89273              
  Branches      13473    13473              
============================================
+ Hits          54346    54356      +10     
+ Misses        29333    29325       -8     
+ Partials       5594     5592       -2     
Flag Coverage Δ
integration-tests-java21 32.14% <ø> (+<0.01%) ⬆️
integration-tests-java8 32.21% <ø> (+<0.01%) ⬆️
samples-tests-java21 32.13% <ø> (-0.07%) ⬇️
samples-tests-java8 29.84% <ø> (+0.05%) ⬆️
unit-tests-java11 59.14% <ø> (+0.02%) ⬆️
unit-tests-java17 58.59% <ø> (-0.06%) ⬇️
unit-tests-java21 58.60% <ø> (-0.01%) ⬇️
unit-tests-java25 58.54% <ø> (-0.03%) ⬇️
unit-tests-java8 59.16% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants