fix: resolve FileInputStream resource leak in IOUtils.readLines(File) - #16401
Closed
lxcxjxhx wants to merge 1 commit into
Closed
fix: resolve FileInputStream resource leak in IOUtils.readLines(File)#16401lxcxjxhx wants to merge 1 commit into
lxcxjxhx wants to merge 1 commit into
Conversation
Use try-with-resources to ensure FileInputStream is properly closed in IOUtils.readLines(File) method, preventing potential file handle leaks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16401 +/- ##
============================================
- Coverage 60.87% 60.67% -0.21%
+ Complexity 11766 11218 -548
============================================
Files 1953 1953
Lines 89273 89274 +1
Branches 13473 13473
============================================
- Hits 54346 54165 -181
- Misses 29333 29480 +147
- Partials 5594 5629 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
This change serves no purpose because the underlying stream is already closed internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Fix a FileInputStream resource leak in
IOUtils.readLines(File).What does this PR fix?
In
IOUtils.readLines(File file), aFileInputStreamis created inline and passed toreadLines(InputStream). If an exception occurs during reading, the underlying file handle is never closed, leading to a file descriptor leak.Checklist
IOUtils.readLines(File))read(InputStream, String)but notreadLines(File)Note
Apologies for any inconvenience. Due to local environment limitations (Windows without full JDK/Maven setup for Dubbo), I am relying on CI/CD for automated testing.