Skip to content

draft: router rule delivery integration - #1530

Closed
xiaobaicai66695 wants to merge 7 commits into
apache:developfrom
xiaobaicai66695:feature/admin-router-rule-chain
Closed

draft: router rule delivery integration#1530
xiaobaicai66695 wants to merge 7 commits into
apache:developfrom
xiaobaicai66695:feature/admin-router-rule-chain

Conversation

@xiaobaicai66695

@xiaobaicai66695 xiaobaicai66695 commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Purpose

This Draft PR keeps the complete Admin router-rule delivery chain on one branch for final end-to-end validation. Please review the implementation in the child PRs below rather than reviewing this aggregate diff.

Review order

  1. Part 1 — existing Condition/Tag delivery chain
  2. Part 2 — Affinity/Script Admin backend and configuration-center delivery
  3. Part 3 — rule-management UI and Condition v3.1 editing

The child PRs are hosted in the contributor fork and form a dependency chain in the order above.

Integration boundary

Together, the child PRs cover Admin rule modeling, Console APIs, YAML encoding/decoding, ZooKeeper/Nacos delivery and readback, and the traffic-rule UI.

This PR does not change dubbo-go RouterChain, router factory registration, or provider-selection logic. Dynamic Config v3 runtime parsing/matching is handled separately in apache/dubbo-go#3660.

Validation

  • Part 1 focused Go tests passed.
  • Part 2 focused backend packages passed. The aggregate pkg/console test needs the embedded frontend dist directory, which is unavailable in the isolated split worktree.
  • Part 3 frontend tests passed: 9 files / 18 tests.
  • The top child branch is code-equivalent to this integration branch for all committed Admin changes.

After the child PRs are reviewed, this branch will be used for the final Admin → configuration center → dubbo-go E2E check.

@xiaobaicai66695
xiaobaicai66695 marked this pull request as draft August 31, 2026 06:03
@xiaobaicai66695 xiaobaicai66695 changed the title feat: align router rule delivery and management chain draft: router rule delivery integration Aug 31, 2026
@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

@xiaobaicai66695

Copy link
Copy Markdown
Contributor Author

Closing this draft because the router-rule changes will be reorganized into smaller fork-internal PRs based on feature/router-rule-integration for easier review before submitting to apache/develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant