Skip to content

branch-4.0: [bug](cloud restore) rewrite table properties and partition info in cloud restore#64465

Open
xy720 wants to merge 2 commits into
apache:branch-4.0from
xy720:fix-restore-dnm
Open

branch-4.0: [bug](cloud restore) rewrite table properties and partition info in cloud restore#64465
xy720 wants to merge 2 commits into
apache:branch-4.0from
xy720:fix-restore-dnm

Conversation

@xy720

@xy720 xy720 commented Jun 12, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

pick #63696

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

xy720 and others added 2 commits June 12, 2026 17:42
…loud restore (apache#63696)

In cloud mode, rewrite all unsupported table properties and some
partition info from the source cluster.

These table properties (e.g., dynamic_partition.replication_num,
dynamic_partition.replication_allocation,
dynamic_partition.storage_policy, in_memory,
storage_medium,min_load_replica_num...) are not applicable in cloud
mode.

And rewrite some non-applicable partition info as well.

If kept, they would cause some critical problems.

For example, dynamic partition scheduler creates new partitions with
source cluster replication settings, leading to write failures like:
"alive replica num < 1 load required replica num 2".
@xy720 xy720 requested a review from morningman as a code owner June 12, 2026 10:13
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xy720

xy720 commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 62.50% (20/32) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants