Skip to content

branch-4.1:[improvement](maxcompute) Simplify FE block ID requests for MaxCompute writes (#62880)#64447

Open
hubgeter wants to merge 2 commits into
apache:branch-4.1from
hubgeter:pick_mc_client
Open

branch-4.1:[improvement](maxcompute) Simplify FE block ID requests for MaxCompute writes (#62880)#64447
hubgeter wants to merge 2 commits into
apache:branch-4.1from
hubgeter:pick_mc_client

Conversation

@hubgeter

Copy link
Copy Markdown
Contributor

pick #62880

What problem does this PR solve?

Related PR: #62578

  1. PR [opt](maxcompute)Allocate write block ids from FE and add catalog-level write_max_block_bytes prop. #62578 moved MaxCompute write block ID allocation from BE-local counters to
    Instead of calling FE through the BE JNI C++ bridge:

MaxCompute connector Java -> BE JNI C++ -> FE
the MaxCompute connector now requests FE directly through thrift:
MaxCompute connector Java -> FE

A new MaxComputeFeClient is added under the MaxCompute connector to handle FE
methods.

  1. Removes the hardcoded MAX_BLOCK_COUNT variable from

fe/fe-core/src/main/java/org/apache/doris/datasource/maxcompute/MCTransaction.java
and moves it to the FE config max_compute_write_max_block_count
The default value is still 20000, so the existing behavior is preserved.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…e writes (apache#62880)

### What problem does this PR solve?
Related PR: apache#62578

1. PR apache#62578 moved MaxCompute write block ID allocation from BE-local
counters to
  Instead of calling FE through the BE JNI C++ bridge:

  MaxCompute connector Java -> BE JNI C++ -> FE
  the MaxCompute connector now requests FE directly through thrift:
  MaxCompute connector Java -> FE

A new MaxComputeFeClient is added under the MaxCompute connector to
handle FE
  methods.

  2. Removes the hardcoded `MAX_BLOCK_COUNT` variable from

`fe/fe-core/src/main/java/org/apache/doris/datasource/maxcompute/MCTransaction.java`
  and moves it to the FE config `max_compute_write_max_block_count`
The default value is still 20000, so the existing behavior is preserved.
@hubgeter hubgeter requested a review from yiguolei as a code owner June 12, 2026 06:52
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hubgeter hubgeter changed the title [improvement](maxcompute) Simplify FE block ID requests for MaxCompute writes (#62880) branch-4.1:[improvement](maxcompute) Simplify FE block ID requests for MaxCompute writes (#62880) Jun 12, 2026
@hubgeter

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@hubgeter

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.85% (20387/37857)
Line Coverage 37.44% (193363/516500)
Region Coverage 33.84% (150774/445599)
Branch Coverage 34.82% (66005/189540)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.67% (26536/37026)
Line Coverage 54.81% (282023/514582)
Region Coverage 52.25% (234875/449499)
Branch Coverage 53.46% (101597/190027)

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants