fix: use to_bits() comparison for float types in eq_array (#24431) - #24436
Closed
waterWang wants to merge 1 commit into
Closed
fix: use to_bits() comparison for float types in eq_array (#24431)#24436waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ScalarValue::eq_arrayis documented as an optimized equivalent of extracting an array element withScalarValue::try_from_arrayand comparing the resulting scalars. However, for floating-point valueseq_arrayuses IEEE equality (via the genericeq_array_primitive!macro) whileScalarValue::PartialEqcompares bit representations, producing inconsistent results:ScalarValues but unequal througheq_array.+0.0and-0.0compare unequal asScalarValues but equal througheq_array.Fix
Replace the Float16, Float32, and Float64 branches of
eq_arraywith customto_bits()comparison, matching the semantics ofScalarValue::PartialEqfor floats.Closes #24431