introduce new dictionary benchmarks - #24416
Open
Rich-T-kid wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
cc @saadtajwar @kumarUjjawal 🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24416 +/- ##
==========================================
+ Coverage 81.23% 81.25% +0.02%
==========================================
Files 1111 1112 +1
Lines 390208 391578 +1370
Branches 390208 391578 +1370
==========================================
+ Hits 316990 318186 +1196
- Misses 54591 54685 +94
- Partials 18627 18707 +80 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
saadtajwar
approved these changes
Aug 17, 2026
saadtajwar
left a comment
saadtajwar
left a comment
Contributor
There was a problem hiding this comment.
Nice! Will definitely make sure to use this for #24089
kumarUjjawal
left a comment
kumarUjjawal
left a comment
Contributor
There was a problem hiding this comment.
Thank you @Rich-T-kid
I left two comments. Please let me know what you think.
Rich-T-kid
force-pushed
the
rich-T-kid/cache-dictionary-arc-ptr
branch
from
August 18, 2026 04:27
200910d to
e76e389
Compare
Contributor
Author
@kumarUjjawal thank you for the review, e76e389 should address your comments 🚀 |
kumarUjjawal
approved these changes
Aug 18, 2026
kumarUjjawal
left a comment
kumarUjjawal
left a comment
Contributor
There was a problem hiding this comment.
Thank you for iteration.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The existing benchmarks only cover the vectorized (GroupOrdering::None) intern/emit path. This adds coverage for the scalar append_val/equal_to path and the rolling EmitTo::First (take-n) emit path.
What changes are included in this PR?
Two new benchmarks in benches/dictionary_group_values.rs:
Are these changes tested?
n/a
Are there any user-facing changes?
n/a