feat: support multiply_ym_interval with YearMonth interval codegen dispatch#4715
Open
peterxcli wants to merge 2 commits into
Open
feat: support multiply_ym_interval with YearMonth interval codegen dispatch#4715peterxcli wants to merge 2 commits into
peterxcli wants to merge 2 commits into
Conversation
peterxcli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4540.
Rationale for this change
This adds support for Spark's
multiply_ym_intervalexpression, allowing YearMonth interval multiplication to run through Comet instead of falling back toSpark.
What changes are included in this PR?
YearMonthIntervalTypeserialization to the Comet proto/native type mapping.MakeYMIntervalandMultiplyYMIntervalthrough the JVM codegen dispatcher.IntervalYearVectorinput/output support in the codegen kernel path.How are these changes tested?
cargo fmt./mvnw -Pspark-3.5 -Pscala-2.12 -DskipTests compilecargo +1.94.0 check -p datafusion-cometcargo +1.94.0 build./mvnw test -Pspark-3.5 -Pscala-2.12 -Dtest=none -Dsuites="org.apache.comet.CometSqlFileTestSuite multiply_ym_interval"