[CALCITE-7642] RelToSqlConverter may generate duplicate output column names for case-insensitive dialects#5077
Open
zzwqqq wants to merge 1 commit into
Open
[CALCITE-7642] RelToSqlConverter may generate duplicate output column names for case-insensitive dialects#5077zzwqqq wants to merge 1 commit into
zzwqqq wants to merge 1 commit into
Conversation
… names for case-insensitive dialects
|
Member
|
I added a comment in jira. |
Contributor
Author
@xiedeyantu Thanks for reviewing. I replied on the JIRA issue with a more precise description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7642
Changes Proposed
RelToSqlConverter may emit duplicate output column names for case-insensitive dialects, for example
idandID.Row type field names are uniquified according to the type factory, which may not match the target SQL dialect's case-sensitivity.
This patch uses the dialect's case-sensitivity when uniquifying output field names, and keeps the affected SELECT-list generation paths on the same aliasing logic.
Adds regression tests.