Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two strings still give
SyntaxWarning: invalid escape sequenceon Python 3.12+. Theb_psycopg2.pyone shows up in CI'stest-persister-dbsjob on main. Future Python versions plan to make it an error.Changes
b_psycopg2.py: thePostgreSQLPersisterdocstring has'\ 'in its docker example (line 41), so it's now a raw string.s3client.py:allowed_chars = r"a-zA-Z0-9_\-"in_allowed_project_name(line 101), the same fix b7547ed made inburr/tracking/client.py. The S3 client was added a few days before that and kept the old line.How I tested this
.pyfile in the repo with warnings on: 2SyntaxWarnings on main, none here.allowed_charsare identical before and after, and_allowed_project_namegives the same result on main and here for a set of project names, with and without Windows.Notes
Both strings keep exactly the same value, so the only change is the missing warning.
This was done with AI assistance (Claude Code), and checked by running the tests described above.
Checklist