[derrickaw]

#35030

[derrickaw]

/gemini review

[github-actions]

📋 Review Summary

This PR adds a Beam YAML example pipeline (pubsub_to_splunk.yaml) and an end-to-end integration test (extended_tests/e2e/pubsub_to_splunk.yaml) demonstrating reading from Pub/Sub, transforming events, writing to Splunk HEC, and routing failed writes to a Pub/Sub dead-letter topic. It also introduces the temp_pubsub_subscriptions fixture in integration_tests.py to support bounded Pub/Sub reading and writing with FnApiRunner.

🔍 General Feedback

• The pipeline definitions and test preprocessors integrate cleanly with the existing Beam YAML testing framework.
• There are a couple of resource management and error-handling improvements needed in temp_pubsub_subscriptions (integration_tests.py), as well as a nullable field handling edge case in the E2E test's dead-letter mapping.

---

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.75%. Comparing base (0f1ac43) to head (8866239).
⚠️ Report is 22 commits behind head on master.

Files with missing lines	Patch %	Lines
sdks/python/apache_beam/yaml/integration_tests.py	0.00%	73 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #40885       +/-   ##
===========================================
+ Coverage        0   79.75%   +79.75%     
===========================================
  Files           0      494      +494     
  Lines           0    83646    +83646     
===========================================
+ Hits            0    66712    +66712     
- Misses          0    16934    +16934     

Flag	Coverage Δ
python	79.75% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Assigning reviewers:

R: @chamikaramj for label yaml.
Backup reviewer: Abacn (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).