Skip to content

ARTEMIS-6130 Clarify artemis check queue command options#6544

Open
brusdev wants to merge 1 commit into
apache:mainfrom
brusdev:ARTEMIS-6130
Open

ARTEMIS-6130 Clarify artemis check queue command options#6544
brusdev wants to merge 1 commit into
apache:mainfrom
brusdev:ARTEMIS-6130

Conversation

@brusdev

@brusdev brusdev commented Jun 29, 2026

Copy link
Copy Markdown
Member

No description provided.

@vitorpmoreira

vitorpmoreira commented Jun 29, 2026

Copy link
Copy Markdown

Hi! Vitor here from the email thread that reported the issue.
Maybe you also make it clear what happens if you have 0 messages in the queue. If I'm not mistaken, the check passes, since its a "try to browse/consume if available, but don't fail if there's nothing".

What about "Number of messages to browse or -1 to browse at most 1 message if one is immediately available. The check succeeds if no message is available."?

@brusdev

brusdev commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

@vitorpmoreira I added your clarification in brackets to avoid users thinking it is true also when the value is not -1

private boolean up;

@Option(names = "--browse", description = "Number of the messages to browse or -1 to check that the queue is browsable.")
@Option(names = "--browse", description = "Number of the messages to browse or -1 to browse at most 1 message only if it is immediately available (succeeding also if no messages are available).")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brusdev Is there a default value? perhaps you could specify (default = X) on the description).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, at least not through the cli. You must pass the --consume value. If you don't, you'll get an error.
image

If you pass a value lower than -1, you'll get an error.
image

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm there is no default value. @clebertsuconic are you suggesting adding a default value?

private Integer browse;

@Option(names = "--consume", description = "Number of the messages to consume or -1 to check that the queue is consumable.")
@Option(names = "--consume", description = "Number of the messages to consume or -1 to consume at most 1 message only if it is immediately available (succeeding also if no messages are available).")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants