Repository navigation
Conversation
…ctionary fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When dictionary encoding is enabled,
WriterProperties::Builder::encodingrejects dictionary encodings as fallback encodings, yet the column writer ignores the configured encoding and always falls back toPLAINwhen the dictionary overflows or Arrow dictionary chunks differ. Incompatible encoding/type combinations on dictionary-enabled columns also go unnoticed until fallback happens at runtime.What changes are included in this PR?
PLAINon dictionary fallback.PLAINfallback encoders upfront on writer creation so incompatible encodings fail immediately rather than mid-write.WriterProperties::Builder::encodingdocstrings to match.Are these changes tested?
Yes, added unit tests for dictionary fallback with non-
PLAINencodings (V1/V2 pages, spaced/unspaced writes, and Arrow dictionary arrays) and for upfront rejection of incompatible encodings.Are there any user-facing changes?
Yes. Columns with both dictionary encoding enabled and an explicit encoding set now fall back to that encoding instead of
PLAIN, and incompatible fallback encodings now fail on writer creation.Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
Used AI to help draft unit tests and check edge cases.
PR code and description written by:
Reviewed before submission by: